Improve typing and optimize Comparison
#1283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Sentry found no issues in your recent changes ✅ |
giovanni-guidini
approved these changes
Apr 11, 2025
This primarily improves some typings related to `Comparison/Report`, adds some tracing, and removes the need to initialize the related `Repository` when initializing the `ArchiveService` as that is not needed.
Swatinem
force-pushed
the
swatinem/load-comparison
branch
from
c9c243e to
a7826d8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1283 +/- ##
=======================================
Coverage 96.35% 96.35%
=======================================
Files 488 488
Lines 16919 16919
=======================================
Hits 16302 16302
Misses 617 617
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
spalmurray
approved these changes
Apr 14, 2025
JerrySentry
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This primarily improves some typings related to
Comparison/Report, adds some tracing, and removes the need to initialize the relatedRepositorywhen initializing theArchiveServiceas that is not needed.