Skip to content

Fix: resolve quick bug for results invalid type #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025
Merged

Conversation

RulaKhaled
Copy link
Contributor

Purpose/Motivation

What is the feature? Why is this being done?
Should resolve https://codecov.sentry.io/issues/6331041997/?environment=production&project=5514400&query=is%3Aunresolved%20issue.priority%3A%5Bhigh%2C%20medium%5D&referrer=issue-stream&sort=date&stream_index=3

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@RulaKhaled RulaKhaled requested a review from a team as a code owner April 11, 2025 18:51
@RulaKhaled RulaKhaled changed the title resolve quick bug for results invalid type Fix: resolve quick bug for results invalid type Apr 11, 2025
Copy link
Contributor

✅ Sentry found no issues in your recent changes ✅

@RulaKhaled RulaKhaled enabled auto-merge April 11, 2025 18:57
@codecov-notifications
Copy link

codecov-notifications bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.35%. Comparing base (9fd0ef4) to head (f2f7812).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1287   +/-   ##
=======================================
  Coverage   96.35%   96.35%           
=======================================
  Files         488      488           
  Lines       16919    16919           
=======================================
  Hits        16302    16302           
  Misses        617      617           
Flag Coverage Δ
unit 96.35% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RulaKhaled RulaKhaled added this pull request to the merge queue Apr 11, 2025
Merged via the queue into main with commit d3f7e91 Apr 11, 2025
23 of 24 checks passed
@RulaKhaled RulaKhaled deleted the resolve-bug branch April 11, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants