Skip to content

style: refactor Desktop client for readability and maintainability #12723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 9, 2025

Conversation

Saracomethstein
Copy link
Contributor

What I did
Refactored the Desktop client to improve readability, maintainability, and error handling.
Key changes include:

  • Simplified HTTP request logic
  • Consolidated error handling with newHTTPStatusCodeError
  • Ensured consistent use of defer resp.Body.Close() to prevent resource leaks
  • Removed redundant code and improved structure
  • Renamed unclear variables for better clarity

Related issue

  • N/A

(not mandatory) A picture of a cute animal, if possible in relation to what you did

@Saracomethstein Saracomethstein requested a review from a team as a code owner April 8, 2025 19:23
@ndeloof
Copy link
Contributor

ndeloof commented Apr 9, 2025

for legal reason we require contributor's commits to be signed-off. Please use git commit --amend --signoff and force-push you branch

Signed-off-by: Adel Sevastianov <102406080+Saracomethstein@users.noreply.github.com>
@Saracomethstein Saracomethstein force-pushed the refactor/desktop-client branch from ca04026 to 0384a3d Compare April 9, 2025 09:34
@Saracomethstein
Copy link
Contributor Author

Ready!

@glours glours enabled auto-merge (rebase) April 9, 2025 09:51
auto-merge was automatically disabled April 9, 2025 11:00

Head branch was pushed to by a user without write access

Signed-off-by: Adel Sevastianov <102406080+Saracomethstein@users.noreply.github.com>
@Saracomethstein Saracomethstein force-pushed the refactor/desktop-client branch from caa8843 to 44ee322 Compare April 9, 2025 11:02
@glours glours merged commit 846161d into docker:main Apr 9, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants