Skip to content

introduce volume.type=image #12725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2025
Merged

introduce volume.type=image #12725

merged 1 commit into from
Apr 9, 2025

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Apr 9, 2025 •
edited
Loading

What I did
introduce support for mounting an image as volume

volume image pull progress is displayed in compose UI as a psuedo-service:

⠼ myservice:volume 0 [⣿⣿⣿⣿⣿⣿⣿] 67.97MB / 68.63MB Pulling                                                                                                                                                    9.5s 
   ✔ 16c9c4a8e9ee Pull complete                                                                                                                                                                          7.6s 
   ⠼ 2e2bf7652052 Extracting      [>                                                  ]    426kB/40.56MB                                                                                                 7.7s 
   ✔ 38095d7651ea Download complete                                                                                                                                                                      0.4s 
   ✔ 656814a9b758 Download complete                                                                                                                                                                      1.1s

requires #12725

Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did

@ndeloof ndeloof requested a review from a team as a code owner April 9, 2025 08:07
@ndeloof ndeloof requested a review from glours April 9, 2025 08:07
@ndeloof ndeloof force-pushed the image_volume branch 2 times, most recently from 698c6a1 to e149d3d Compare April 9, 2025 08:21
@ndeloof ndeloof mentioned this pull request Apr 9, 2025
Merged
@ndeloof
introduce volume.type=image
bbd3a3c 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
glours
glours approved these changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours merged commit 01e83de into docker:main Apr 9, 2025
26 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Apr 10, 2025
Merged
@rancherbot rancherbot mentioned this pull request Apr 10, 2025
Merged
@fabiang fabiang mentioned this pull request Apr 17, 2025
Open
@perosb perosb mentioned this pull request Apr 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glours glours

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndeloof @glours