prefer bind API #12734
Merged
prefer bind API #12734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
commented
Apr 11, 2025
| @@ -874,8 +866,8 @@ func (s *composeService) buildContainerVolumes( | |||
| v := findVolumeByTarget(service.Volumes, m.Target) | |||
| vol := findVolumeByName(p.Volumes, m.Source) | |||
| if v != nil && vol != nil { | |||
| if _, ok := vol.DriverOpts["device"]; ok && vol.Driver == "local" && vol.DriverOpts["o"] == "bind" { | |||
There was a problem hiding this comment.
removed this earlier fix, as with volumeRequiresMountAPI we will prefer bind for all volumes without advanced mount options, not just those created with o=bind
ndeloof
commented
Apr 11, 2025
| @@ -838,13 +837,7 @@ func (s *composeService) buildContainerVolumes( | |||
| var mounts []mount.Mount | |||
| var binds []string | |||
|
|
|||
| img := api.GetImageNameOrDefault(service, p.Name) | |||
There was a problem hiding this comment.
moved to buildContainerMountOptions as this is only used when we manage anonymous volumes inheritance (allows to write test without a useless API call/mock)
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
force-pushed
the
bind_vs_mount_test
branch
from
5ba1af3 to
d5753b2
Compare
|
@ndeloof Will this fix be available in 2.36.0 release? |
|
@vg22 the issue should be fixed in the latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Always prefer
bindAPI for volumes overmountwhen not required.added a test case to check various combinations
Related issue
test to prevent regression reported on #12121
(not mandatory) A picture of a cute animal, if possible in relation to what you did