Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: http.timeout default does not match the documentation #373

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

erunion
Copy link
Contributor

@erunion erunion commented Feb 26, 2025

Ran into a fun problem today where while running a test case that was processing 4,000+ schemas my tests began to slow to a crawl. Thinking it was a fetch problem I dug into the documentation and noticed that the docs mention http.timeout having a 5s default.

Turns out it's actually 60s! 😰

This drops the http.timeout default down to 5s in order to match the docs.

@jonluca
Copy link
Collaborator

jonluca commented Feb 26, 2025

We should probably change it so that the docs say that the timeout is 60s rather than changing the default. This release might break peoples existing workflows.

I think a Readme / docs update is better

@coveralls
Copy link

coveralls commented Feb 26, 2025

Pull Request Test Coverage Report for Build 13555607321

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 92.613%

Totals Coverage Status
Change from base Build 13294318699: -0.2%
Covered Lines: 1624
Relevant Lines: 1722

💛 - Coveralls

@erunion
Copy link
Contributor Author

erunion commented Feb 26, 2025

@jonluca Sounds good! Just pushed that up.

@jonluca
Copy link
Collaborator

jonluca commented Feb 26, 2025

awesome, thanks!

@jonluca jonluca merged commit 5303da9 into APIDevTools:main Feb 26, 2025
11 checks passed
Copy link

🎉 This PR is included in version 11.9.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@erunion erunion deleted the fix/wrong-http-timeout branch February 26, 2025 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants