[OCPBUGS-42396]Add variable reference for resource_requests_limits rules

[xiaojiey]

Description:

Add variable reference for resource_requests_limits_in_daemonset, resource_requests_limits_in_deployment and resource_requests_limits_in_statefuleset rules.

[jan-cerny]

@xiaojiey Please fill in the PR description.

[BhargaviGudi]

Verification passed with 4.18.0-0.nightly-2025-02-19-132725 + compliance-operator from https://github.com/ComplianceAsCode/compliance-operator + PR #12987 code

$ oc get rule -o custom-columns=NAME:metadata.name,VARIABLE:metadata.annotations.compliance\\.openshift\\.io/rule-variable --no-headers | grep resource-requests-limits | grep upstream
upstream-ocp4-resource-requests-limits-in-daemonset                                          var-daemonset-limit-namespaces-exempt-regex
upstream-ocp4-resource-requests-limits-in-deployment                                         var-deployment-limit-namespaces-exempt-regex
upstream-ocp4-resource-requests-limits-in-statefulset                                        var-statefulset-limit-namespaces-exempt-regex

[xiaojiey]

/hold

[openshift-ci]

@xiaojiey: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/4.13-images	00821b0	link	true	/test 4.13-images
ci/prow/4.16-images	00821b0	link	true	/test 4.16-images
ci/prow/4.17-images	00821b0	link	true	/test 4.17-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[codeclimate]

Code Climate has analyzed commit 00821b0 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 62.1% (0.0% change).

View more on Code Climate.

[Vincent056]

There are two locations in the operator code requiring fixes in order to address this bug:

1. First:

At line 998, the existing implementation is not correctly appending all necessary text for parsing values. This function should be updated to the following:

func listNodeFields(node parse.Node, res []string) []string {
	if node.Type() != parse.NodeNil {
		res = append(res, node.String())
	}

	if ln, ok := node.(*parse.ListNode); ok {
		for _, n := range ln.Nodes {
			res = listNodeFields(n, res)
		}
	}
	return res
}

2. Second Issue:

The logic at this location in the same file needs to be updated so we will return a list of rendered values like https://github.com/ComplianceAsCode/compliance-operator/blob/adbd9f10adcd52c7f3d516b4705aff9b3bb86d75/pkg/profileparser/profileparser.go#L649C1-L650C1

No changes are required for the profile part; only the parsing logic needs to be adjusted as described above.

[rhmdnd]

This will redirect to https://docs.redhat.com/en/documentation/openshift_container_platform/4.18/html/building_applications/deployments#deployments-setting-resources_deployment-operations now - we could update it here to use docs.redhat.com so we don't have to later.