[template]: fixes in file_owner template #13070

alanmcanonical · 2025-02-17T17:40:08Z

Description:

Add uid_or_name parameter for template file_owner similar to fixes in file_groupownership template #10666

Rationale:

We need to dynamically read uid from /etc/passwd to be more reliable

openshift-ci · 2025-02-17T17:40:18Z

Hi @alanmcanonical. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

github-actions · 2025-02-17T21:11:21Z

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff

bash remediation for rule 'xccdf_org.ssgproject.content_rule_file_owner_systemmap' differs.
--- xccdf_org.ssgproject.content_rule_file_owner_systemmap
+++ xccdf_org.ssgproject.content_rule_file_owner_systemmap
@@ -1,2 +1,2 @@
 
-find -L /boot/ -maxdepth 1 -type f ! -uid 0 -regextype posix-extended -regex '^.*System\.map.*$' -exec chown -L 0 {} \;
+find -L /boot/ -maxdepth 1 -type f ! -user 0 -regextype posix-extended -regex '^.*System\.map.*$' -exec chown -L 0 {} \;

ansible remediation for rule 'xccdf_org.ssgproject.content_rule_file_owner_systemmap' differs.
--- xccdf_org.ssgproject.content_rule_file_owner_systemmap
+++ xccdf_org.ssgproject.content_rule_file_owner_systemmap
@@ -1,6 +1,6 @@
 - name: Find /boot/ file(s) matching ^.*System\.map.*$
-  command: find -H /boot/ -maxdepth 1 -type f ! -uid 0 -regextype posix-extended -regex
-    "^.*System\.map.*$"
+  command: find -H /boot/ -maxdepth 1 -type f ! -user 0 -regextype posix-extended
+    -regex "^.*System\.map.*$"
   register: files_found
   changed_when: false
   failed_when: false

ansible remediation for rule 'xccdf_org.ssgproject.content_rule_file_groupowner_var_log_syslog' differs.
--- xccdf_org.ssgproject.content_rule_file_groupowner_var_log_syslog
+++ xccdf_org.ssgproject.content_rule_file_groupowner_var_log_syslog
@@ -1,7 +1,19 @@
+- name: Gather the package facts
+  package_facts:
+    manager: auto
+  tags:
+  - configure_strategy
+  - file_groupowner_var_log_syslog
+  - low_complexity
+  - low_disruption
+  - medium_severity
+  - no_reboot_needed
+
 - name: Test for existence /var/log/syslog
   stat:
     path: /var/log/syslog
   register: file_exists
+  when: '"rsyslog" in ansible_facts.packages'
   tags:
   - configure_strategy
   - file_groupowner_var_log_syslog
@@ -14,7 +26,9 @@
   file:
     path: /var/log/syslog
     group: '4'
-  when: file_exists.stat is defined and file_exists.stat.exists
+  when:
+  - '"rsyslog" in ansible_facts.packages'
+  - file_exists.stat is defined and file_exists.stat.exists
   tags:
   - configure_strategy
   - file_groupowner_var_log_syslog

Platform has been changed for rule 'xccdf_org.ssgproject.content_rule_file_groupowner_var_log_syslog'
--- xccdf_org.ssgproject.content_rule_file_groupowner_var_log_syslog
+++ xccdf_org.ssgproject.content_rule_file_groupowner_var_log_syslog
@@ -1 +1 @@
-
+oval:ssg-package_rsyslog:def:1

ansible remediation for rule 'xccdf_org.ssgproject.content_rule_file_owner_var_log_syslog' differs.
--- xccdf_org.ssgproject.content_rule_file_owner_var_log_syslog
+++ xccdf_org.ssgproject.content_rule_file_owner_var_log_syslog
@@ -1,7 +1,6 @@
-- name: Test for existence /var/log/syslog
-  stat:
-    path: /var/log/syslog
-  register: file_exists
+- name: Gather the package facts
+  package_facts:
+    manager: auto
   tags:
   - configure_strategy
   - file_owner_var_log_syslog
@@ -10,11 +9,11 @@
   - medium_severity
   - no_reboot_needed
 
-- name: Ensure owner 0 on /var/log/syslog
-  file:
+- name: Test for existence /var/log/syslog
+  stat:
     path: /var/log/syslog
-    owner: '0'
-  when: file_exists.stat is defined and file_exists.stat.exists
+  register: file_exists
+  when: '"rsyslog" in ansible_facts.packages'
   tags:
   - configure_strategy
   - file_owner_var_log_syslog
@@ -22,3 +21,18 @@
   - low_disruption
   - medium_severity
   - no_reboot_needed
+
+- name: Ensure owner syslog on /var/log/syslog
+  file:
+    path: /var/log/syslog
+    owner: syslog
+  when:
+  - '"rsyslog" in ansible_facts.packages'
+  - file_exists.stat is defined and file_exists.stat.exists
+  tags:
+  - configure_strategy
+  - file_owner_var_log_syslog
+  - low_complexity
+  - low_disruption
+  - medium_severity
+  - no_reboot_needed

Platform has been changed for rule 'xccdf_org.ssgproject.content_rule_file_owner_var_log_syslog'
--- xccdf_org.ssgproject.content_rule_file_owner_var_log_syslog
+++ xccdf_org.ssgproject.content_rule_file_owner_var_log_syslog
@@ -1 +1 @@
-
+oval:ssg-package_rsyslog:def:1

bash remediation for rule 'xccdf_org.ssgproject.content_rule_file_ownership_library_dirs' differs.
--- xccdf_org.ssgproject.content_rule_file_ownership_library_dirs
+++ xccdf_org.ssgproject.content_rule_file_ownership_library_dirs
@@ -1,8 +1,8 @@
 
-find  /lib/  -type f ! -uid 0 -regextype posix-extended -regex '^.*$' -exec chown -L 0 {} \;
+find  /lib/  -type f ! -user 0 -regextype posix-extended -regex '^.*$' -exec chown -L 0 {} \;
 
-find  /lib64/  -type f ! -uid 0 -regextype posix-extended -regex '^.*$' -exec chown -L 0 {} \;
+find  /lib64/  -type f ! -user 0 -regextype posix-extended -regex '^.*$' -exec chown -L 0 {} \;
 
-find  /usr/lib/  -type f ! -uid 0 -regextype posix-extended -regex '^.*$' -exec chown -L 0 {} \;
+find  /usr/lib/  -type f ! -user 0 -regextype posix-extended -regex '^.*$' -exec chown -L 0 {} \;
 
-find  /usr/lib64/  -type f ! -uid 0 -regextype posix-extended -regex '^.*$' -exec chown -L 0 {} \;
+find  /usr/lib64/  -type f ! -user 0 -regextype posix-extended -regex '^.*$' -exec chown -L 0 {} \;

ansible remediation for rule 'xccdf_org.ssgproject.content_rule_file_ownership_library_dirs' differs.
--- xccdf_org.ssgproject.content_rule_file_ownership_library_dirs
+++ xccdf_org.ssgproject.content_rule_file_ownership_library_dirs
@@ -1,5 +1,5 @@
 - name: Find /lib/ file(s) matching ^.*$ recursively
-  command: find -H /lib/  -type f ! -uid 0 -regextype posix-extended -regex "^.*$"
+  command: find -H /lib/  -type f ! -user 0 -regextype posix-extended -regex "^.*$"
   register: files_found
   changed_when: false
   failed_when: false
@@ -40,7 +40,7 @@
   - no_reboot_needed
 
 - name: Find /lib64/ file(s) matching ^.*$ recursively
-  command: find -H /lib64/  -type f ! -uid 0 -regextype posix-extended -regex "^.*$"
+  command: find -H /lib64/  -type f ! -user 0 -regextype posix-extended -regex "^.*$"
   register: files_found
   changed_when: false
   failed_when: false
@@ -81,7 +81,7 @@
   - no_reboot_needed
 
 - name: Find /usr/lib/ file(s) matching ^.*$ recursively
-  command: find -H /usr/lib/  -type f ! -uid 0 -regextype posix-extended -regex "^.*$"
+  command: find -H /usr/lib/  -type f ! -user 0 -regextype posix-extended -regex "^.*$"
   register: files_found
   changed_when: false
   failed_when: false
@@ -122,7 +122,7 @@
   - no_reboot_needed
 
 - name: Find /usr/lib64/ file(s) matching ^.*$ recursively
-  command: find -H /usr/lib64/  -type f ! -uid 0 -regextype posix-extended -regex
+  command: find -H /usr/lib64/  -type f ! -user 0 -regextype posix-extended -regex
     "^.*$"
   register: files_found
   changed_when: false

bash remediation for rule 'xccdf_org.ssgproject.content_rule_file_cron_allow_exists' differs.
--- xccdf_org.ssgproject.content_rule_file_cron_allow_exists
+++ xccdf_org.ssgproject.content_rule_file_cron_allow_exists
@@ -2,7 +2,6 @@
 if rpm --quiet -q kernel; then
 
 touch /etc/cron.allow
-    chown 0 /etc/cron.allow
     chmod 0600 /etc/cron.allow
 
 else

ansible remediation for rule 'xccdf_org.ssgproject.content_rule_file_cron_allow_exists' differs.
--- xccdf_org.ssgproject.content_rule_file_cron_allow_exists
+++ xccdf_org.ssgproject.content_rule_file_cron_allow_exists
@@ -14,7 +14,6 @@
   file:
     path: /etc/cron.allow
     state: touch
-    owner: '0'
     mode: '0600'
   when: '"kernel" in ansible_facts.packages'
   tags:

bash remediation for rule 'xccdf_org.ssgproject.content_rule_file_ownership_sshd_private_key' differs.
--- xccdf_org.ssgproject.content_rule_file_ownership_sshd_private_key
+++ xccdf_org.ssgproject.content_rule_file_ownership_sshd_private_key
@@ -1,7 +1,7 @@
 # Remediation is applicable only in certain platforms
 if rpm --quiet -q kernel; then
 
-find -L /etc/ssh/ -maxdepth 1 -type f ! -uid 0 -regextype posix-extended -regex '^.*_key$' -exec chown -L 0 {} \;
+find -L /etc/ssh/ -maxdepth 1 -type f ! -user 0 -regextype posix-extended -regex '^.*_key$' -exec chown -L 0 {} \;
 
 else
     >&2 echo 'Remediation is not applicable, nothing was done'

ansible remediation for rule 'xccdf_org.ssgproject.content_rule_file_ownership_sshd_private_key' differs.
--- xccdf_org.ssgproject.content_rule_file_ownership_sshd_private_key
+++ xccdf_org.ssgproject.content_rule_file_ownership_sshd_private_key
@@ -11,7 +11,7 @@
   - no_reboot_needed
 
 - name: Find /etc/ssh/ file(s) matching ^.*_key$
-  command: find -H /etc/ssh/ -maxdepth 1 -type f ! -uid 0 -regextype posix-extended
+  command: find -H /etc/ssh/ -maxdepth 1 -type f ! -user 0 -regextype posix-extended
     -regex "^.*_key$"
   register: files_found
   changed_when: false

bash remediation for rule 'xccdf_org.ssgproject.content_rule_file_ownership_sshd_pub_key' differs.
--- xccdf_org.ssgproject.content_rule_file_ownership_sshd_pub_key
+++ xccdf_org.ssgproject.content_rule_file_ownership_sshd_pub_key
@@ -1,7 +1,7 @@
 # Remediation is applicable only in certain platforms
 if rpm --quiet -q kernel; then
 
-find -L /etc/ssh/ -maxdepth 1 -type f ! -uid 0 -regextype posix-extended -regex '^.*\.pub$' -exec chown -L 0 {} \;
+find -L /etc/ssh/ -maxdepth 1 -type f ! -user 0 -regextype posix-extended -regex '^.*\.pub$' -exec chown -L 0 {} \;
 
 else
     >&2 echo 'Remediation is not applicable, nothing was done'

ansible remediation for rule 'xccdf_org.ssgproject.content_rule_file_ownership_sshd_pub_key' differs.
--- xccdf_org.ssgproject.content_rule_file_ownership_sshd_pub_key
+++ xccdf_org.ssgproject.content_rule_file_ownership_sshd_pub_key
@@ -11,7 +11,7 @@
   - no_reboot_needed
 
 - name: Find /etc/ssh/ file(s) matching ^.*\.pub$
-  command: find -H /etc/ssh/ -maxdepth 1 -type f ! -uid 0 -regextype posix-extended
+  command: find -H /etc/ssh/ -maxdepth 1 -type f ! -user 0 -regextype posix-extended
     -regex "^.*\.pub$"
   register: files_found
   changed_when: false

bash remediation for rule 'xccdf_org.ssgproject.content_rule_file_ownership_audit_configuration' differs.
--- xccdf_org.ssgproject.content_rule_file_ownership_audit_configuration
+++ xccdf_org.ssgproject.content_rule_file_ownership_audit_configuration
@@ -1,9 +1,9 @@
 # Remediation is applicable only in certain platforms
 if rpm --quiet -q audit && rpm --quiet -q kernel; then
 
-find -L /etc/audit/ -maxdepth 1 -type f ! -uid 0 -regextype posix-extended -regex '^.*audit(\.rules|d\.conf)$' -exec chown -L 0 {} \;
+find -L /etc/audit/ -maxdepth 1 -type f ! -user 0 -regextype posix-extended -regex '^.*audit(\.rules|d\.conf)$' -exec chown -L 0 {} \;
 
-find -L /etc/audit/rules.d/ -maxdepth 1 -type f ! -uid 0 -regextype posix-extended -regex '^.*\.rules$' -exec chown -L 0 {} \;
+find -L /etc/audit/rules.d/ -maxdepth 1 -type f ! -user 0 -regextype posix-extended -regex '^.*\.rules$' -exec chown -L 0 {} \;
 
 else
     >&2 echo 'Remediation is not applicable, nothing was done'

ansible remediation for rule 'xccdf_org.ssgproject.content_rule_file_ownership_audit_configuration' differs.
--- xccdf_org.ssgproject.content_rule_file_ownership_audit_configuration
+++ xccdf_org.ssgproject.content_rule_file_ownership_audit_configuration
@@ -11,7 +11,7 @@
   - no_reboot_needed
 
 - name: Find /etc/audit/ file(s) matching ^.*audit(\.rules|d\.conf)$
-  command: find -H /etc/audit/ -maxdepth 1 -type f ! -uid 0 -regextype posix-extended
+  command: find -H /etc/audit/ -maxdepth 1 -type f ! -user 0 -regextype posix-extended
     -regex "^.*audit(\.rules|d\.conf)$"
   register: files_found
   changed_when: false
@@ -49,7 +49,7 @@
   - no_reboot_needed
 
 - name: Find /etc/audit/rules.d/ file(s) matching ^.*\.rules$
-  command: find -H /etc/audit/rules.d/ -maxdepth 1 -type f ! -uid 0 -regextype posix-extended
+  command: find -H /etc/audit/rules.d/ -maxdepth 1 -type f ! -user 0 -regextype posix-extended
     -regex "^.*\.rules$"
   register: files_found
   changed_when: false

github-actions · 2025-02-17T21:11:38Z

Change in Ansible shell module found.

Please consider using more suitable Ansible module than shell if possible.

github-actions · 2025-02-17T22:14:07Z

Change in Ansible shell module found.

Please consider using more suitable Ansible module than shell if possible.

github-actions · 2025-02-18T07:37:17Z

Change in Ansible shell module found.

Please consider using more suitable Ansible module than shell if possible.

github-actions · 2025-02-19T15:29:28Z

Change in Ansible shell module found.

Please consider using more suitable Ansible module than shell if possible.

github-actions · 2025-02-20T01:05:42Z

Change in Ansible shell module found.

Please consider using more suitable Ansible module than shell if possible.

alanmcanonical · 2025-02-20T03:01:37Z

The audit pkg issue caused by rule file_ownership_audit_configuration # packages = audit, I checked ubi8 image which yum search audit indeed return no result. So probably rhel needs a package override.

dodys

please do a rebase on top of master

dodys

tests are failing a lot, please check logs

github-actions · 2025-02-25T12:32:58Z

Change in Ansible shell module found.

Please consider using more suitable Ansible module than shell if possible.

dodys · 2025-02-25T14:29:11Z

@ComplianceAsCode/red-hatters @ComplianceAsCode/suse-maintainers @ComplianceAsCode/oracle-maintainers
could you take a look if we are not breaking anything for you?

Xeicker

LGTM

teacup-on-rockingchair

Good stuff 👍 Besides the tests fixes everything else looks great to me 🙇

dodys

@alanmcanonical tests are still failing.

github-actions · 2025-03-05T09:47:09Z

Change in Ansible shell module found.

Please consider using more suitable Ansible module than shell if possible.

dodys · 2025-03-05T14:13:19Z

/packit build

change parameter fileuid of file_owner template to uid_or_name explain its behavior

change the parameter name from filgeuid to uid_or_name additionally, use the -user parameter instead of -uid parameter in find command invocation the -user parameter accepts both uid and user names, where the -uid parameter accepts only uid

establish a new variable which carries information if the parameter is a uid or a user name

decide if to user ID or user name based on the variable declared in the preprocessing function change parameter name from file_uid to uid_or_name

…plate from fileuid to uid_or_name

github-actions · 2025-03-06T08:54:26Z

Change in Ansible shell module found.

Please consider using more suitable Ansible module than shell if possible.

alanmcanonical · 2025-03-09T06:13:46Z

The file_owner_var_log_syslog-incorrect_owner.fail.sh-remediation.verbose.log shows:

TASK [Gather the package facts] ************************************************
[skip some log for clearness]
...
...
<localhost> SSH: EXEC ssh -C -o ControlMaster=auto -o ControlPersist=60s -o KbdInteractiveAuthentication=no -o PreferredAuthentications=gssapi-with-mic,gssapi-keyex,hostbased,publickey -o PasswordAuthentication=no -o 'User="root"' -o ConnectTimeout=10 -o Port=35135 -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -o 'ControlPath="/home/runner/.ansible/cp/72dc686b8e"' -tt localhost '/bin/sh -c '"'"'/usr/bin/python3 /root/.ansible/tmp/ansible-tmp-1741253229.205663-61782-134313576207627/AnsiballZ_package_facts.py && sleep 0'"'"''
(1, b'Traceback (most recent call last):\r\n  File \x1b[35m"<string>"\x1b[0m, line \x1b[35m1\x1b[0m, in \x1b[35m<module>\x1b[0m\r\n    import rpm\r\n\x1b[1;35mModuleNotFoundError\x1b[0m: \x1b[35mNo module named \'rpm\'\x1b

Seems like this anisble snippet from build/rhel8/fixes/ansible/file_owner_var_log_syslog.yml is problematic

  package_facts:
    manager: auto

more log:

<localhost> (1, b'Traceback (most recent call last):\r\n  File \x1b[35m"<string>"\x1b[0m, line \x1b[35m1\x1b[0m, in \x1b[35m<module>\x1b[0m\r\n    import rpm\r\n\x1b[1;35mModuleNotFoundError\x1b[0m: \x1b[35mNo module named \'rpm\'\x1b[0m\r\n\r\n{"failed": true, "msg": "Could not detect a supported package manager from the following list: [\'rpm\', \'pacman\', \'pkg_info\', \'pkg\', \'apt\', \'apk\', \'portage\'], or the required Python library is not installed. Check warnings for details.", "invocation": {"module_args": {"manager": ["auto"], "strategy": "first"}}, "warnings": ["Found \\"rpm\\" but Failed to import the required Python library (rpm) on c96b3ba27c3d\'s Python /usr/bin/python3. Please read the module documentation and install it in the appropriate location. If the required library is installed, but Ansible is using the wrong Python interpreter, please consult the documentation on ansible_python_interpreter"]}\r\n', b'Shared connection to localhost closed.\r\n')

alanmcanonical · 2025-03-09T06:31:16Z

Updates:

according to https://docs.ansible.com/ansible/latest/collections/ansible/builtin/package_facts_module.html#requirements

here is the requirement:

"rpm": For RPM based distros, requires RPM Python bindings, not installed by default on Suse (python3-rpm)

github-actions · 2025-03-09T14:37:48Z

Change in Ansible shell module found.

Please consider using more suitable Ansible module than shell if possible.

github-actions · 2025-03-10T15:46:09Z

Change in Ansible shell module found.

Please consider using more suitable Ansible module than shell if possible.

github-actions · 2025-03-10T16:08:55Z

Change in Ansible shell module found.

Please consider using more suitable Ansible module than shell if possible.

codeclimate · 2025-03-10T16:38:04Z

Code Climate has analyzed commit 0aefdd1 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Duplication	2

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 62.0% (0.0% change).

View more on Code Climate.

alanmcanonical · 2025-03-11T09:22:09Z

Make all the automatus tests passed except those on Debian 12 and UBI8 which are package installation errors.

dodys

lgtm, thanks!

openshift-ci bot added the needs-ok-to-test label Feb 17, 2025

alanmcanonical marked this pull request as draft February 17, 2025 21:04

openshift-ci bot added the do-not-merge/work-in-progress label Feb 17, 2025

alanmcanonical force-pushed the uid_rt branch from 296d790 to 3507fcf Compare February 17, 2025 21:06

alanmcanonical force-pushed the uid_rt branch from c118ea9 to dc65c70 Compare February 18, 2025 07:32

dodys self-assigned this Feb 18, 2025

alanmcanonical marked this pull request as ready for review February 20, 2025 02:09

openshift-ci bot removed the do-not-merge/work-in-progress label Feb 20, 2025

dodys requested changes Feb 24, 2025

View reviewed changes

alanmcanonical force-pushed the uid_rt branch from 5ad3d08 to d32f45f Compare February 24, 2025 15:51

dodys added this to the 0.1.77 milestone Feb 25, 2025

dodys requested changes Feb 25, 2025

View reviewed changes

alanmcanonical force-pushed the uid_rt branch from d32f45f to be9a901 Compare February 25, 2025 12:27

dodys requested review from a team February 25, 2025 14:28

Xeicker approved these changes Feb 26, 2025

View reviewed changes

teacup-on-rockingchair approved these changes Mar 2, 2025

View reviewed changes

dodys requested changes Mar 4, 2025

View reviewed changes

alanmcanonical added 10 commits March 6, 2025 16:45

Update template documentation:

5e3bc4f

change parameter fileuid of file_owner template to uid_or_name explain its behavior

change the parameter name in template tests

6b4c3d2

modify remediations for file_owner template

5cfe328

change the parameter name from filgeuid to uid_or_name additionally, use the -user parameter instead of -uid parameter in find command invocation the -user parameter accepts both uid and user names, where the -uid parameter accepts only uid

modify the preprocessing function of file_owner template

01d8dc7

establish a new variable which carries information if the parameter is a uid or a user name

modify the oval for file_owner template

8dee9f6

decide if to user ID or user name based on the variable declared in the preprocessing function change parameter name from file_uid to uid_or_name

modify rule.yaml files to change the parameter name of file_owner tem…

e8621df

…plate from fileuid to uid_or_name

Package rsyslog create the user syslog

4115dc6

Override the template tests

cfaba0a

Create user syslog if no exist

bf4358e

Fix "components"

3717806

alanmcanonical force-pushed the uid_rt branch from d474535 to 3717806 Compare March 6, 2025 08:46

Add required python module

f371649

Create dummy in case there is no file exist

0aefdd1

alanmcanonical force-pushed the uid_rt branch from 46ccbc0 to 0aefdd1 Compare March 10, 2025 16:03

dodys approved these changes Mar 12, 2025

View reviewed changes

dodys merged commit 02f241a into ComplianceAsCode:master Mar 12, 2025
98 of 102 checks passed

alanmcanonical mentioned this pull request Mar 12, 2025

Revert the uid back to rsyslog for the rule file_owner_var_log_syslog #13169

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[template]: fixes in file_owner template #13070

[template]: fixes in file_owner template #13070

alanmcanonical commented Feb 17, 2025

openshift-ci bot commented Feb 17, 2025

github-actions bot commented Feb 17, 2025 •

edited

Loading

github-actions bot commented Feb 17, 2025

github-actions bot commented Feb 17, 2025

github-actions bot commented Feb 18, 2025

github-actions bot commented Feb 19, 2025

github-actions bot commented Feb 20, 2025

alanmcanonical commented Feb 20, 2025

dodys left a comment

dodys left a comment

github-actions bot commented Feb 25, 2025

dodys commented Feb 25, 2025

Xeicker left a comment

teacup-on-rockingchair left a comment

dodys left a comment

github-actions bot commented Mar 5, 2025

dodys commented Mar 5, 2025

github-actions bot commented Mar 6, 2025

alanmcanonical commented Mar 9, 2025 •

edited

Loading

alanmcanonical commented Mar 9, 2025

github-actions bot commented Mar 9, 2025

github-actions bot commented Mar 10, 2025

github-actions bot commented Mar 10, 2025

codeclimate bot commented Mar 10, 2025

alanmcanonical commented Mar 11, 2025

dodys left a comment

[template]: fixes in file_owner template #13070

[template]: fixes in file_owner template #13070

Conversation

alanmcanonical commented Feb 17, 2025

Description:

Rationale:

openshift-ci bot commented Feb 17, 2025

github-actions bot commented Feb 17, 2025 • edited Loading

github-actions bot commented Feb 17, 2025

github-actions bot commented Feb 17, 2025

github-actions bot commented Feb 18, 2025

github-actions bot commented Feb 19, 2025

github-actions bot commented Feb 20, 2025

alanmcanonical commented Feb 20, 2025

dodys left a comment

Choose a reason for hiding this comment

dodys left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 25, 2025

dodys commented Feb 25, 2025

Xeicker left a comment

Choose a reason for hiding this comment

teacup-on-rockingchair left a comment

Choose a reason for hiding this comment

dodys left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 5, 2025

dodys commented Mar 5, 2025

github-actions bot commented Mar 6, 2025

alanmcanonical commented Mar 9, 2025 • edited Loading

alanmcanonical commented Mar 9, 2025

github-actions bot commented Mar 9, 2025

github-actions bot commented Mar 10, 2025

github-actions bot commented Mar 10, 2025

codeclimate bot commented Mar 10, 2025

alanmcanonical commented Mar 11, 2025

dodys left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 17, 2025 •

edited

Loading

alanmcanonical commented Mar 9, 2025 •

edited

Loading