Fix accounts_password_pam_retry #13144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rule `accounts_password_pam_retry` failed after kickstart or Anaconda installation. The problem is that the rule passes in the initial scan but fails in the final scan because in the initial scan the rule `enable_authselect` fails and the remediation for `enable_authselect` made `accounts_password_pam_retry` fail but remediation for `accounts_password_pam_retry` isn't executed because it passed in the initial scan. Fixes: ComplianceAsCode#12277 Used test: `/hardening/anaconda/anssi_bp28_high` on RHEL 9
jan-cerny
added
OVAL
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
This datastream diff is auto generated by the check Click here to see the full diffOVAL for rule 'xccdf_org.ssgproject.content_rule_accounts_password_pam_retry' differs.
--- oval:ssg-accounts_password_pam_retry:def:1
+++ oval:ssg-accounts_password_pam_retry:def:1
@@ -1,3 +1,5 @@
+criteria AND
+extend_definition oval:ssg-enable_authselect:def:1
criteria OR
criteria AND
criterion oval:ssg-test_password_pam_pwquality_retry_password_auth:tst:1 |
|
Code Climate has analyzed commit cd0138d and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 62.1% (0.0% change). View more on Code Climate. |
|
/packit build |
|
/packit delete |
|
/packit build |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Mab879
approved these changes
Mar 7, 2025
|
Waving Automatus tests as contest tests pass. |
jan-cerny
added a commit
to jan-cerny/contest
that referenced
this pull request
Mar 10, 2025
A fix has been merged by ComplianceAsCode/content#13144
matusmarhefka
pushed a commit
to RHSecurityCompliance/contest
that referenced
this pull request
Mar 10, 2025
A fix has been merged by ComplianceAsCode/content#13144
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rule
accounts_password_pam_retryfailed after kickstart or Anaconda installation. The problem is that the rule passes in the initial scan but fails in the final scan because in the initial scan the ruleenable_authselectfails and the remediation forenable_authselectmadeaccounts_password_pam_retryfail but remediation foraccounts_password_pam_retryisn't executed because it passed in the initial scan.Fixes: #12277
Used test:
/hardening/anaconda/anssi_bp28_highon RHEL 9