Fail if the build causes empty OCIL #13148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If building a single rule data stream we need to check if the OCIL in that rule isn't empty otherwise we would build an invalid single rule data stream because it would have empty questionnaires element.
|
Code Climate has analyzed commit 2cdd8ec and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 0.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 62.0% (-0.1% change). View more on Code Climate. |
Mab879
approved these changes
Mar 6, 2025
|
/packit retest-failed |
|
Waving the coverage tests as this code is run during the build process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If building a single rule data stream we need to check if the OCIL in that rule isn't empty otherwise we would build an invalid single rule data stream because it would have empty questionnaires element.
Review Hints:
ocilandocil_clausefrom your favorite rule (or create a new rule that doesn't have these keys)../build_product -r your_favorite_rule product_id