OPENSCAP-5464: Use more fine granular audit rules for E8 and ISM profiles in RHEL #13149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of audit_rules_usergroup_modification use audit_rules_usergroup_modification_group audit_rules_usergroup_modification_gshadow audit_rules_usergroup_modification_opasswd audit_rules_usergroup_modification_passwd audit_rules_usergroup_modification_shadow
In RHEL10 ISM_O control file since the original rule doesn't have ansible remediation.
|
/packit retest-failed |
1 similar comment
|
/packit retest-failed |
|
/packit retest-failed |
jan-cerny
requested changes
Mar 10, 2025
| @@ -107,7 +107,6 @@ selections: | |||
| - audit_rules_login_events_tallylog | |||
| - audit_rules_login_events_faillock | |||
| - audit_rules_login_events_lastlog | |||
| - audit_rules_login_events | |||
There was a problem hiding this comment.
Please add the removed rules to the RHEL 9 default profile so that they will be kept in the built RHEL 9 data stream.
jan-cerny
requested changes
Mar 10, 2025
| @@ -574,3 +574,4 @@ selections: | |||
| - file_permissions_etc_audit_rulesd | |||
| - configure_openssl_tls_crypto_policy | |||
| - configure_openssl_crypto_policy | |||
| - audit_rules_login_events | |||
There was a problem hiding this comment.
Please add also the other removed rules (audit_rules_usergroup_modification and audit_rules_unsuccessful_file_modification) to prevent their removal from RHEL 9 data stream.
|
Code Climate has analyzed commit e7cb339 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 62.0% (0.0% change). View more on Code Climate. |
jan-cerny
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Rationale:
Fixes #13125