Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(release): Set gitconfig before git write operations #32277

Merged
merged 4 commits into from
Feb 13, 2025
+51 −30
Merged

feat(release): Set gitconfig before git write operations #32277

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5ea6a0f
feat(release): Set gitconfig before git write operations
chouetz Dec 17, 2024
ff2ceb4
fix tests and update post rebase
chouetz Feb 12, 2025
731a3c0
codereview: Set a default empty value for github_workflow_url
chouetz Feb 13, 2025
122cddf
fix tests
chouetz Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
codereview: Set a default empty value for github_workflow_url
  • Loading branch information
@chouetz
chouetz committed Feb 13, 2025
commit 731a3c031adfe8ee13acfb7edad19cee97e5a7f3
8 changes: 6 additions & 2 deletions tasks/release.py
View file
Original file line number Diff line number Diff line change
@@ -40,7 +40,7 @@
)
from tasks.libs.common.gomodules import get_default_modules
from tasks.libs.common.user_interactions import yes_no_question
from tasks.libs.common.utils import set_gitconfig_in_ci
from tasks.libs.common.utils import running_in_github_actions, set_gitconfig_in_ci
from tasks.libs.common.worktree import agent_context
from tasks.libs.pipeline.notifications import (
DEFAULT_JIRA_PROJECT,
@@ -1349,7 +1349,11 @@ def bump_integrations_core(ctx, slack_webhook=None):
"""
Create a PR to bump the integrations core fields in the release.json file
"""
github_workflow_url = f"{os.environ.get('GITHUB_SERVER_URL', 'github.com')}/{GITHUB_REPO_NAME}/actions/runs/{os.environ.get('GITHUB_RUN_ID', '1')}"
github_workflow_url = ""
if running_in_github_actions():
github_workflow_url = (
f"{os.environ.get('GITHUB_SERVER_URL')}/{GITHUB_REPO_NAME}/actions/runs/{os.environ.get('GITHUB_RUN_ID')}"
)
commit_hash = get_git_references(ctx, "integrations-core", "HEAD").split()[0]

rj = load_release_json()
Loading
Oops, something went wrong.