Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SVLS] Fix serverless integration tests - updates QEMU #34583

Merged
merged 3 commits into from
Feb 28, 2025

Conversation

jcstorms1
Copy link
Contributor

@jcstorms1 jcstorms1 commented Feb 28, 2025

What does this PR do?

This updates QEMU to the latest release. Previously, the Ubuntu runner update caused an issue with QEMU where we were receiving a gcc segmentation fault and test were failing, leading to blocked builds. Updating to the newest version fixes the build failure.

It also reverts a change which was hidden by this failure, where gzip compression breaks distribution metrics in the serverless context

https://github.com/docker/setup-qemu-action/releases/tag/v3.6.0

Motivation

Failed builds and actions/runner-images#11662 (comment)

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@jcstorms1 jcstorms1 requested review from a team as code owners February 28, 2025 15:20
@jcstorms1 jcstorms1 changed the title update qemu [SVLS] Fix serverless integration tests - updates QEMU Feb 28, 2025
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Feb 28, 2025
@astuyve astuyve added qa/no-code-change No code change in Agent code requiring validation and removed team/serverless labels Feb 28, 2025
@jcstorms1 jcstorms1 added changelog/no-changelog team/serverless and removed qa/no-code-change No code change in Agent code requiring validation labels Feb 28, 2025
@astuyve astuyve added qa/no-code-change No code change in Agent code requiring validation changelog/no-changelog and removed changelog/no-changelog labels Feb 28, 2025
@jcstorms1 jcstorms1 added this to the Triage milestone Feb 28, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 28, 2025

Uncompressed package size comparison

Comparison with ancestor cdbffb7cecfde454d1dfcfa493368393abc14a03

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 815.22MB 815.22MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB 825.01MB 825.01MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 825.01MB 825.01MB 0.50MB
datadog-agent-arm64-deb 0.00MB 806.19MB 806.19MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB 815.96MB 815.96MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 39.42MB 39.42MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 39.50MB 39.50MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 39.50MB 39.50MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 37.96MB 37.96MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 440.65MB 440.65MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 62.09MB 62.09MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 62.16MB 62.16MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 62.16MB 62.16MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 59.33MB 59.33MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 59.40MB 59.40MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 28, 2025

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 788.88MiB 801.8MiB 192.3MiB 202.62MiB
static_quality_gate_agent_deb_arm64 780.17MiB 793.14MiB 174.2MiB 184.51MiB
static_quality_gate_agent_rpm_amd64 788.94MiB 801.79MiB 194.34MiB 205.03MiB
static_quality_gate_agent_rpm_arm64 780.3MiB 793.09MiB 175.91MiB 186.44MiB
static_quality_gate_agent_suse_amd64 788.88MiB 801.81MiB 194.34MiB 205.03MiB
static_quality_gate_agent_suse_arm64 780.3MiB 793.14MiB 175.91MiB 186.44MiB
static_quality_gate_dogstatsd_deb_amd64 37.67MiB 47.67MiB 9.78MiB 19.78MiB
static_quality_gate_dogstatsd_deb_arm64 36.28MiB 46.27MiB 8.49MiB 18.49MiB
static_quality_gate_dogstatsd_rpm_amd64 37.67MiB 47.67MiB 9.79MiB 19.79MiB
static_quality_gate_dogstatsd_suse_amd64 37.67MiB 47.67MiB 9.79MiB 19.79MiB
static_quality_gate_iot_agent_deb_amd64 59.29MiB 69.0MiB 14.89MiB 24.8MiB
static_quality_gate_iot_agent_deb_arm64 56.65MiB 66.4MiB 12.87MiB 22.8MiB
static_quality_gate_iot_agent_rpm_amd64 59.29MiB 69.0MiB 14.92MiB 24.8MiB
static_quality_gate_iot_agent_rpm_arm64 56.66MiB 66.4MiB 12.86MiB 22.8MiB
static_quality_gate_iot_agent_suse_amd64 59.29MiB 69.0MiB 14.92MiB 24.8MiB
static_quality_gate_docker_agent_amd64 873.6MiB 886.12MiB 293.87MiB 304.21MiB
static_quality_gate_docker_agent_arm64 888.25MiB 900.79MiB 280.1MiB 290.47MiB
static_quality_gate_docker_agent_jmx_amd64 1.05GiB 1.06GiB 368.96MiB 379.33MiB
static_quality_gate_docker_agent_jmx_arm64 1.05GiB 1.06GiB 351.21MiB 361.55MiB
static_quality_gate_docker_dogstatsd_amd64 45.82MiB 55.78MiB 17.28MiB 27.28MiB
static_quality_gate_docker_dogstatsd_arm64 44.45MiB 54.45MiB 16.16MiB 26.16MiB
static_quality_gate_docker_cluster_agent_amd64 264.99MiB 274.78MiB 106.36MiB 116.28MiB
static_quality_gate_docker_cluster_agent_arm64 280.95MiB 290.82MiB 101.19MiB 111.12MiB

Copy link

cit-pr-commenter bot commented Feb 28, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 92139095-03f2-4513-b8bb-edef5ae515ae

Baseline: cdbffb7
Comparison: 74a80a8
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +4.05 [+1.04, +7.06] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +2.53 [+1.61, +3.44] 1 Logs
quality_gate_idle_all_features memory utilization +0.36 [+0.31, +0.41] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.35 [-0.12, +0.82] 1 Logs
file_tree memory utilization +0.34 [+0.28, +0.40] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.02 [-0.85, +0.90] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.29, +0.32] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.00 [-0.62, +0.63] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.00 [-0.77, +0.77] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.02, +0.02] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.00 [-0.87, +0.87] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.01 [-0.69, +0.68] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.04 [-0.83, +0.74] 1 Logs
quality_gate_idle memory utilization -0.42 [-0.46, -0.38] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput -0.89 [-1.66, -0.12] 1 Logs
tcp_syslog_to_blackhole ingress throughput -1.26 [-1.31, -1.21] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

@astuyve astuyve requested a review from a team as a code owner February 28, 2025 17:53
@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=57378215 --os-family=ubuntu

Note: This applies to commit 74a80a8

@astuyve
Copy link
Contributor

astuyve commented Feb 28, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 28, 2025

View all feedbacks in Devflow UI.
2025-02-28 19:16:24 UTC ℹ️ Start processing command /merge


2025-02-28 19:16:28 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 33m.


2025-02-28 19:54:40 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit b31a048 into main Feb 28, 2025
245 checks passed
@dd-mergequeue dd-mergequeue bot deleted the storms/update-serverless-integration-test branch February 28, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/serverless
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants