Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async Finding Import: Mark the feature as deprecated #11915

Merged
merged 7 commits into from
Mar 7, 2025

Conversation

Jino-T
Copy link
Contributor

@Jino-T Jino-T commented Feb 28, 2025

  • Added warnings to async_process_findings

  • Added comments in settings.dist.py

Note:
I took the text for the warnings and comments from the documentation . Let me know if I should change this text to something potentially more helpful.

[sc-6355]

@github-actions github-actions bot added the settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR label Feb 28, 2025
Copy link

dryrunsecurity bot commented Feb 28, 2025

DryRun Security Summary

Deprecation warnings have been added for DefectDojo's experimental async finding import feature across multiple files to alert users about potential inconsistencies and data integrity issues starting from version 2.44.0.

Expand for full summary

The PR adds deprecation warnings to async finding import features across multiple files in DefectDojo, indicating the experimental feature's deprecation as of version 2.44.0. Security findings include:

  1. Potential inconsistency risks with experimental async finding import feature across base_importer.py, default_importer.py, default_reimporter.py, and settings.dist.py
  2. Warning users about potential data integrity issues when using deprecated async processing methods
  3. Proactive communication of experimental feature limitations that could lead to unexpected results

No direct security vulnerabilities were identified in the patch.

Code Analysis

We ran 7 analyzers against 4 files and 1 analyzer had findings. 6 analyzers had no findings.

Analyzer Findings
Configured Codepaths Analyzer 3 findings

Overall Riskiness

🔴 Risk threshold exceeded.

We've notified @mtesauro, @grendel513.

View PR in the DryRun Dashboard.

@Jino-T Jino-T closed this Feb 28, 2025
@Jino-T Jino-T reopened this Feb 28, 2025
@mtesauro mtesauro changed the title OS Dojo Async Finding Import: Mark the feature as deprecated Async Finding Import: Mark the feature as deprecated Feb 28, 2025
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Jino-T Jino-T requested a review from dogboat March 6, 2025 00:55
@Maffooch Maffooch merged commit 3e69fa6 into DefectDojo:dev Mar 7, 2025
70 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants