Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLA Calculations 1/2: Add unit tests to capture current behaviour #11923

Open
wants to merge 7 commits into
base: bugfix
Choose a base branch
from

Conversation

valentijnscholten
Copy link
Member

Adds some unit tests to capture current behaviour:

  • to understand the calculation that does some magic with days remaining
  • to make sure we don't regress in the future if we simplify the calculation, or add business days support.

@github-actions github-actions bot removed the ui label Mar 1, 2025
@valentijnscholten valentijnscholten changed the title SLA Calculations: Add unit tests to capture current behaviour SLA Calculations 1/2: Add unit tests to capture current behaviour Mar 6, 2025
@valentijnscholten valentijnscholten marked this pull request as ready for review March 12, 2025 17:25
Copy link

DryRun Security Summary

A new unit test file for SLA calculations in DefectDojo is added, with five test methods and a security finding related to potential information disclosure through logging configuration.

Expand for full summary

The PR introduces a new unit test file for SLA calculations in DefectDojo, implementing five test methods to validate various SLA scenarios. Security findings include: 1) Potential information disclosure risk from logging configuration if log levels are not properly set in production, as noted in the file's security analysis section.

View PR in the DryRun Dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant