-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SLA Calculations 2/2: Simplify logic #11924
base: bugfix
Are you sure you want to change the base?
SLA Calculations 2/2: Simplify logic #11924
Conversation
f8a07e3
to
109dd9e
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
DryRun Security SummaryThe PR enhances SLA-related functionality in the Finding model by updating expiration date calculation, modifying template tag variables, and adding comprehensive unit tests, while also addressing potential security risks in test logging and data handling. Expand for full summaryThe PR updates the SLA expiration date calculation in the Finding model, modifies template tag variable names, and adds comprehensive SLA calculation unit tests. Security findings:
|
If #11923 gets merged, we have unit tests to capture the SLA calculation behaviour.
So we can now simplify the logic to make it easier to understand, maintain and (possibly) add business days support.