Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLA Calculations 2/2: Simplify logic #11924

Open
wants to merge 7 commits into
base: bugfix
Choose a base branch
from

Conversation

valentijnscholten
Copy link
Member

If #11923 gets merged, we have unit tests to capture the SLA calculation behaviour.

So we can now simplify the logic to make it easier to understand, maintain and (possibly) add business days support.

@valentijnscholten valentijnscholten changed the base branch from master to bugfix March 1, 2025 08:54
Copy link
Contributor

github-actions bot commented Mar 3, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

github-actions bot commented Mar 3, 2025

Conflicts have been resolved. A maintainer will review the pull request shortly.

@valentijnscholten valentijnscholten changed the title SLA Calculations: Simplify logic SLA Calculations 2/2: Simplify logic Mar 6, 2025
@valentijnscholten valentijnscholten marked this pull request as ready for review March 12, 2025 17:25
Copy link

DryRun Security Summary

The PR enhances SLA-related functionality in the Finding model by updating expiration date calculation, modifying template tag variables, and adding comprehensive unit tests, while also addressing potential security risks in test logging and data handling.

Expand for full summary

The PR updates the SLA expiration date calculation in the Finding model, modifies template tag variable names, and adds comprehensive SLA calculation unit tests.

Security findings:

  1. Potential information disclosure risk in test logging (unittests/test_sla_calculations.py): Logging statements may print finding and SLA configuration details that could expose sensitive information if logs are not properly secured.
  2. Test data handling risk (unittests/test_sla_calculations.py): Uses a fixture and hardcoded test data that might contain sensitive credentials or test information.

View PR in the DryRun Dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant