Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruff: Add and autofix B009 #11950

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Ruff: Add and autofix B009 #11950

merged 1 commit into from
Mar 11, 2025
+8 −7

Conversation

kiblik
Copy link
Contributor

@kiblik kiblik commented Mar 5, 2025

Add ruff rule get-attr-with-constant (B009) and use autofix

mtesauro
mtesauro approved these changes Mar 8, 2025
View reviewed changes
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@dryrunsecurity DryRunSecurity
Copy link

dryrunsecurity bot commented Mar 11, 2025 •
edited
Loading

DryRun Security Summary

A pull request with minor code refactoring and the addition of a linting rule (B009) was reviewed, with potential security benefits for detecting unsafe object creation patterns.

Expand for full summary

The PR introduces minor code refactoring across multiple files, simplifying attribute access and adding a linting rule.

Security Findings:

  • In ruff.toml, the addition of linting rule "B009" suggests potential proactive security hardening for detecting unsafe object creation patterns. While not a direct vulnerability, this rule could help prevent potential object manipulation risks.

No other concrete security vulnerabilities were found in the provided patches.

View PR in the DryRun Dashboard.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@mtesauro mtesauro merged commit 51d8ddb into DefectDojo:dev Mar 11, 2025
77 checks passed
@kiblik kiblik deleted the ruff/B009 branch March 11, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtesauro mtesauro

@dogboat dogboat

@hblankenship hblankenship

@Maffooch Maffooch

Assignees
No one assigned
Labels
lint parser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kiblik @mtesauro @dogboat @hblankenship @Maffooch