Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruff: Add and autofix B033 #11954

Merged
merged 2 commits into from
Mar 11, 2025
Merged

Ruff: Add and autofix B033 #11954

merged 2 commits into from
Mar 11, 2025

Conversation

kiblik
Copy link
Contributor

@kiblik kiblik commented Mar 5, 2025

Add rule duplicate-value (B033) and autofix it

@github-actions github-actions bot added the lint label Mar 5, 2025
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link

DryRun Security Summary

A PR updates the dojo/engagement/views.py file's get_product_tab method and adds a Ruff linting rule B033 to improve code security by detecting potential command injection vulnerabilities.

Expand for full summary

The PR modifies the dojo/engagement/views.py file's get_product_tab method and adds a security-related linting rule B033 to the ruff.toml configuration. Security findings include: 1) The added Ruff linting rule B033 targets potential command injection vulnerabilities through unsanitized input() usage, enhancing static code analysis security checks.

View PR in the DryRun Dashboard.

@mtesauro mtesauro merged commit ae3b98e into DefectDojo:dev Mar 11, 2025
77 checks passed
@kiblik kiblik deleted the ruff/B033 branch March 11, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants