dedupe managament command: ensure ordering #11964
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DryRun Security SummaryThe PR updates the dedupe management command to process findings in reverse order by ID, marking newer findings as duplicates of older ones. Expand for full summaryThe PR modifies the dedupe management command to process findings in reverse order by ID, ensuring newer findings are marked as duplicates of older ones. No security vulnerabilities were found in this patch. |
Maffooch
approved these changes
Mar 7, 2025
hblankenship
approved these changes
Mar 11, 2025
dogboat
requested changes
Mar 11, 2025
|
Closing this as the ordering already is in DESC order, no need for the PR (see above). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #11948
For deduplication it's important to start with the newest findings first to make sure the old(est) existing finding is selected as the original. This is already working correctly inside Defect Dojo, but not in the
dedupemanagement command. This PR fixes that.