-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use of angle brackets around file names for include statements #51
Comments
@elfring Doesn't that mean that the library would have to be globally installed for it to build and run properly? Or would the |
I suggest to reconsider the consequences of the following wording from the section "16.2 Source file inclusion" in the standard specification for the programming language "C++".
|
@FlyingGraysons @joshuagruenstein and I are a little unsure of what you are saying. Could you please clarify, @elfring? |
There are different opinions about the handling of the involved implementation-defined behaviour.
|
I believe that:
I doubt that there is a measurable speed difference between the two methods. I may be wrong though. |
Can you imagine use cases where you would like to exclude the search in "local" directories? |
I cannot |
@elfring Can you think of any use cases? |
Yes. - This is the reason for my feature request here. How much do you care where the include files are safely stored for a software library? |
@elfring What is the case? |
I find it important to be reasonably sure that the desired computations were really correct because it could be determined by the applied software build parameters that the used functions were actually derived from the expected source files. Can you follow this design concern? |
What do you mean by this: "the desired computations were really correct"? |
I would generally prefer to exclude the potential for the inclusion of header files from unexpected directories. Can such a security detail become a bit more important occasionally? |
Yes, but the brackets mean that a person would have to specify an include directory, which is slightly annoying. |
Will the mentioned "annoyance" vanish after safe include specifications would be used? |
Yes. This does sound like a good idea. Thank you for the feature request. |
Would specifying the include directory in our g++ compilation command in our makefiles and switching the the brackets fix your specified problem? |
How would you like to distinguish library versions by your software build system? |
Not sure? Any suggestions? |
Feel free to submit a pull request that fixes the problem @elfring |
Would you like to replace any double quotes by angle brackets around file names for include statements?
The text was updated successfully, but these errors were encountered: