Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Change S3 logger to accept more authorization methods for AWS #4114

Merged
merged 2 commits into from
Mar 11, 2025

Conversation

danieldabate
Copy link
Contributor

This PR solves issue #3997 by making environment credentials optional for S3 logger, so they can be taken from different alternative sources like K8S service accounts.

@saqib-ahmed
Copy link

@danieldabate @HenryHengZJ

Can we please add unit/integration tests to prevent this sort of regression in future?

@HenryHengZJ HenryHengZJ merged commit 641df31 into FlowiseAI:main Mar 11, 2025
2 checks passed
@HenryHengZJ
Copy link
Contributor

However, others still have the same problem even though with this fix, are you guys still experiencing the problem? I was suspecting because it doesnt accept credentials: undefined?

I opened a PR (#4166) to only set credentials when both keys are found

@danieldabate
Copy link
Contributor Author

How have you tested it? It is not yet included in the latest release, right?

@HenryHengZJ
Copy link
Contributor

Yep, its not in open source yet, but I've tried to push this in a separate private docker image for enteprise, same problem

@danieldabate
Copy link
Contributor Author

I tested locally in a rush and probably did something wrong, sorry for the trouble 🙏

@HenryHengZJ
Copy link
Contributor

nono i was just wondering thats all, because I was not able to test it out, so asking here and see if others still faces same problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants