-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(permissions): security enchanced #20
Conversation
Added permissions block to limit the permissions use by this job. Only context & metadata are required for the secrets scanning.
Hi, thanks for this contribution. Can you share the content of the code scanning report? We don't have access to it because only owners of the project can read them. I am not sure your changes would fix an issue in your project because the YAML file you changed is used when building the action, in this repository, not when using the action in another repository. |
Hey, you we're indeed correct. I jumped into the conclusion that the README workflow examples are the one in the repo. Can't see any code scanning set up on the repo or at my fork, if you could point me at the right direction I'll happily do that. |
Thanks, this looks good.
I was referring to the description of your pull request. You said:
But the "notified" link does not work for me because it's limited to owners of the zMynx/aws-lambda-calculator repository. I would be interested to have a look at what the tool said there. |
Roger Roger. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
After using this actions for a while, my code scanning tool notified me about a security improvement that can be applied here.
So I've decided to perform some trial and error, and suggest the following changes: