Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Con 27 create pr #71

Merged
merged 28 commits into from
Jul 16, 2021
Merged

Con 27 create pr #71

merged 28 commits into from
Jul 16, 2021

Conversation

SuDa2103
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Jul 13, 2021

Visit the preview URL for this PR (updated for commit d6a6485):

https://gitlive-docs--pr71-con-27-create-pr-wprikfjk.web.app

(expires Fri, 23 Jul 2021 07:54:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Copy link
Contributor

@FredCoen FredCoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep in mind that the changes mention apply to the same sections elsewhere

#### CodeShare

Selecting the share code option starts a collaboration session in your IDE. This means that any file you open will also open in the IDE of the other participant on the call, allowing you to edit together as you would in a google doc. You can even codeshare on files that aren't under source control (such as files ignored in Git) or files from outside the directory (such as external libraries’ source files).
Selecting the share code option opens a dialog, which shows the different projects you have open and the different methods of sharing you have available. You can choose to use JetBrains Code With Me to collaborate, or you can use GitLive's proprietary code sharing solution. You can find more information about using Code With Me here.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selecting the share code option opens up a modal, which shows the different projects you have open and the different methods of pair programming that are available.

eleaborate on when you can share through which method

---
title: Support for Live Share / Code With Me
styleid: sub-nav
subtitle: Seamlessly edit files together in real-time, using IDE specific collaboration tools
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leverage IDE specific collaboration tools for a fully-fledged pair programming experience


#### Starting a Live Share Session

To start a Live Share session, you should select the Live Share tab on the Share Code popup modal, and select the project you would like to share.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mention the condition for this option to appear in the first place

Comment on lines 22 to 27

#### Sharing with GitLive

Sharing with the built-in codeshare and then realise you need the extra power of Live Share? No problem, you can switch from the built-in codeshare to Live Share at any time in VS Code.

![Codeshare Livesharing](/uploads/codeshare-livesharing.jpeg "Codeshare Livesharing"){:class="screenshot"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesnt belong here, its out of context. also rename the title to Switiching from GitLive code share to Live Share

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put it at the bottom of the section

![Live Share Sign In](/uploads/codeshare-liveshare-sign-in.jpeg "Live Share Sign In"){:class="screenshot"}


Once you have signed in, you are good to go!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats not entirely true, link to what the teammate has to do now


#### Joining a Live Share Session

When your teammate starts codesharing via LiveShare or CodeWithMe and you have a compatible IDE already open you will see a prompt to switch to that IDE window.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a confusing, use guest host terminolgy everywhere

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why mention code with me in this section?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont name it compatible IDE name it VS code its only vs code here

![Live Share Open Editor](/uploads/codeshare-liveshare-open-editor.jpg "Live Share Open Editor"){:class="screenshot"}


Here you'll see any notifications regarding joining the codeshare.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here doesnt mean anything

![Live Share Join Collab](/uploads/codeshare-liveshare-join-collab.jpeg "Live Share Join Collab"){:class="screenshot"}


Then your teammate's project will open in a new IDE window and you are good to go!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont use "then"

styleid: sub-nav
subtitle: Seamlessly edit files together in real-time, using IDE specific collaboration tools
author: sunny
subsection: [VS Code, JetBrains, Android Studio]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets have two sections? Live share and Code WIth me


![Share Code](/uploads/codeshare-gitlive-options.jpg "Share Code"){:class="screenshot"}

Selecting the GitLive option is the quickest way to start a collaboration session in your IDE. This means that any file you open will also open in the IDE of the other participant on the call, allowing you to edit together as you would in a google doc. You can even codeshare on files that aren't under source control (such as files ignored in Git) or files from outside the directory (such as external libraries’ source files).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats the difference between ignored in Git and external libraries’ source files

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means that any file you open will also open in the IDE of the other participant on the call

We said guest and host terminoly everywhere, not you and me etc

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elaborate on this means.. you refer to "quickest", what makes it the quickest? the fact that its a one click hassle and you can get started..

also mention what choosing a specific project vs all project does

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By quickest, I meant that Live Share/Code With Me take much longer to load. So literally quickest in terms of time. Did you want me to expand on that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats the difference between ignored in Git and external libraries’ source files

@SuDa2103 ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By quickest, I meant that Live Share/Code With Me take much longer to load. So literally quickest in terms of time. Did you want me to expand on that?

Yes instaed of starting the next senetence with "this means", explain why its quickest, for examply. Simply select share and return to your IDE. Your file navigation will now be followed by the guest, allowing you to edit together as you would in a google doc.


#### Joining a Live Share Session

When your teammate (who will host the code share in this case) starts codesharing via Live Share and you have VS Code open, you will see a prompt to switch to that IDE window.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the host starts a code share via ..


Your teammate's project will then open in a new IDE window and you are good to go!

If you didn't have a compatible IDE already open you will be prompted to open the sharing link in the browser instead.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why compatible IDE if this section is vs code live share and only relates to vs code?

![Accept Live Share](/uploads/codeshare-accept-liveshare.jpeg "Accept Live Share"){:class="screenshot"}


From here you can open a compatible IDE if you already have one installed or even join via the browser.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon joining the session you can install Vs Code or simply join the session via the browser.

Does it prompt you to install after clickin join?

Comment on lines 6 to 7
#### Starting a Live Share Session
If you have the Live Share extension installed on VS Code, you have the option of using Live Share to pair program on your call. To start a Live Share session, you should select the Live Share tab on the Share Code popup modal, and select the project you would like to share.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after the first sentence lets add a sentence, if you havent... install it here (hyperlink)


#### Joining a Code With Me Session

When your teammate starts codesharing via LiveShare or CodeWithMe and you have a compatible IDE already open you will see a prompt to switch to that IDE window.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what did we say about compatible?

![Code With Me Accept User](/uploads/codeshare-codewithme-accept-user.jpg "Code With Me Accept User"){:class="screenshot"}


The guest wll now be able to join the session!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once accepted, the session starts


#### Joining a Code With Me Session

Once the host starts codesharing via CodeWithMe and you have a compatible IDE already open you will see a prompt to switch to that IDE window.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IS code with me onw word?

@FredCoen FredCoen merged commit d080a49 into master Jul 16, 2021
@FredCoen FredCoen deleted the CON-27-create-pr branch July 16, 2021 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants