Skip to content

Commit d36ddfc

Browse files
committedApr 3, 2024
Fix fr DocumentId not working on JS
1 parent bccc1a9 commit d36ddfc

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed
 

‎firebase-firestore/src/jsMain/kotlin/dev/gitlive/firebase/firestore/externals/firestore.kt

+2-3
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,9 @@ import dev.gitlive.firebase.externals.FirebaseApp
88
import kotlin.js.Json
99
import kotlin.js.Promise
1010

11+
external fun documentId(): FieldPath
12+
1113
external class FieldPath(vararg fieldNames: String) {
12-
companion object {
13-
val documentId: FieldPath
14-
}
1514
fun isEqual(other: FieldPath): Boolean
1615

1716
}

‎firebase-firestore/src/jsMain/kotlin/dev/gitlive/firebase/firestore/firestore.kt

+3-2
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import dev.gitlive.firebase.firestore.externals.clearIndexedDbPersistence
1515
import dev.gitlive.firebase.firestore.externals.connectFirestoreEmulator
1616
import dev.gitlive.firebase.firestore.externals.deleteDoc
1717
import dev.gitlive.firebase.firestore.externals.doc
18+
import dev.gitlive.firebase.firestore.externals.documentId as jsDocumentId
1819
import dev.gitlive.firebase.firestore.externals.enableIndexedDbPersistence
1920
import dev.gitlive.firebase.firestore.externals.getDoc
2021
import dev.gitlive.firebase.firestore.externals.getDocs
@@ -440,10 +441,10 @@ actual class SnapshotMetadata(val js: JsSnapshotMetadata) {
440441
actual class FieldPath private constructor(val js: JsFieldPath) {
441442

442443
actual companion object {
443-
actual val documentId = FieldPath(JsFieldPath.documentId)
444+
actual val documentId = FieldPath(jsDocumentId())
444445
}
445446
actual constructor(vararg fieldNames: String) : this(dev.gitlive.firebase.firestore.rethrow {
446-
js("Reflect").construct(JsFieldPath, fieldNames).unsafeCast<JsFieldPath>()
447+
JsFieldPath(*fieldNames)
447448
})
448449
actual val documentId: FieldPath get() = FieldPath.documentId
449450
actual val encoded: EncodedFieldPath = js

0 commit comments

Comments
 (0)
Failed to load comments.