Adding JVM support for Firebase Storage #704
Open
+8
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on previous work by Cesar Ramirez and it is obviously depending on work done on the java sdk: GitLiveApp/firebase-java-sdk#44
I know the checks are failing, I'll need some input on how I can publish a snapshot of
firebase-java-sdkto make them succeed. It all works locally when deploying to maven local.I needed to make sure we never call the firebase storage API with
nullmetadata - when doing this on a desktop target, theCONTENT_LENGTH = 0header gets removed somehow, causing the firebase backend to respond with a HTTP 411. Passing defaults causes a few bytes to be serialized in the first requrest before the upload, which circumvents the problem.The root cause for this must be in the http driver somewhere, as it doesn't happen when running the same code on Android.