-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to use target="_blank"
for anchor tags
#2252
Comments
GitBook does not store and transform markdown into HTML directly. Instead we parse the markdown into our own document format. This document format doesn't support a Also opening links in a new tab is not a good practice for accessibility: https://it.wisc.edu/learn/make-it-accessible/develop-accessible-websites/when-to-open-links-in-a-new-tab/#:~:text=Accessible%20websites-,Accessibility%20considerations,when%20there%20is%20no%20warning. |
@SamyPesse the link you gave also specifies exceptions to the rule.
It also specifies a way to overcome the accessibility issues for these exceptions, by adding a warning to the I think that this should be reopened as there are lots of valid cases to open in a new tab and we could allow that behaviour and maintain good accessibility practice. |
A lot of my users are complainig on docs.sov.ai that when they open my colab links, it opens in the same tab, then they open the docs.sov.ai link again and it automatically sends them back to the colab link. Is this something that can be fixed? |
Bug description
It seems the GitBook renderer ignores the
target
attribute in anchor tags. Could we have this added? There are some "external links" where it makes sense for it to open a new tab instead of having to navigate back and reload the page again.How to reproduce
<a href="https://google.com" target="_blank">Google</a>
in any.md
file in your repo rendered by GitHubtarget
attribute just isn't carried over.Additional context
N/A
The text was updated successfully, but these errors were encountered: