Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scalar Client isn't creating the OpenAPI requests properly #2550

Closed
martinezdylan opened this issue Oct 23, 2024 · 8 comments
Closed

Scalar Client isn't creating the OpenAPI requests properly #2550

martinezdylan opened this issue Oct 23, 2024 · 8 comments
Labels

Comments

@martinezdylan
Copy link

Bug description

The scalar client requests via 'Test it' aren't creating the requests based on the OpenAPI spec. See below:

Screenshot 2024-10-23 at 12 12 26 PM

How to reproduce

  1. Navigate to https://docs.libum.io/nexum/symxchange/api-reference/persistent/informationservice
  2. Click 'Test it'
  3. We'd expect to see the OpenAPI request already pre-filled in the Scalar client where we then just have to add auth

Additional context

This seems to be an almost consistent issue. It'll be fixed, in then all of a sudden with I suppose front-end changes it'll break again. Can we add some stability here or at least QA that this works before upstreaming changes? It's tough claiming we have interactive API docs to later discover they don't function.

@martinezdylan
Copy link
Author

@addisonschultz
Copy link
Contributor

@amritk is this maybe related to yesterday’s PR? #2539

@amritk
Copy link
Contributor

amritk commented Oct 24, 2024

Yes this client is really old, the new one in the PR is much improved!

@amritk
Copy link
Contributor

amritk commented Oct 24, 2024

@martinezdylan the new client also works directly from an openapi spec instead of this current one which depends on specific data + transforms that keep breaking. So it should alleviate your concerns!

@martinezdylan
Copy link
Author

Okay amazing, thanks for putting together that PR. I'll keep an eye for when it gets checked in 🔥

@SamyPesse
Copy link
Member

#2539 has been merged, closing this issue

@marclave
Copy link
Contributor

hi @martinezdylan i just wanted to formally apologize for the stability bugs! like @amritk mentioned we had to rollback our new api client to the old one due to performance issues, luckily we have fixed those and the new client is live!

moving forward it will be incremental improvements, and lots of neat features 😎

appreciate your patience!

@martinezdylan
Copy link
Author

No worries at all, really appreciate the effort here. Thanks @marclave & @amritk for the work and incredible project - we love what y'all are doing 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants