Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spaces list of a site #2441

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix spaces list of a site #2441

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cb9a153
Fix spaces list of a site
taranvohra Aug 28, 2024
408540a
Merge remote-tracking branch 'origin/main' into fix-spaces-list
taranvohra Sep 24, 2024
b1de0ad
get rid of Object.values
taranvohra Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix spaces list of a site
  • Loading branch information
@taranvohra
taranvohra committed Aug 28, 2024
commit cb9a15339df7f1bd050da703cb50e9449df5b280
8 changes: 4 additions & 4 deletions packages/gitbook/src/app/(space)/fetch.ts
View file
Original file line number Diff line number Diff line change
@@ -200,18 +200,18 @@ async function fetchParentSite(args: {
getSiteSpaces({ organizationId, siteId, siteShareKey }),
]);

const spaces: Record<string, Space> = {};
const spaces: Array<Space> = [];
siteSpaces.forEach((siteSpace) => {
spaces[siteSpace.space.id] = {
spaces.push({
...siteSpace.space,
urls: {
...siteSpace.space.urls,
published: siteSpace.urls.published,
},
};
});
});

return { parent: site, spaces: Object.values(spaces) };
return { parent: site, spaces };
}

/**
Loading
Oops, something went wrong.