Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link styles #2861

Merged
merged 9 commits into from
Feb 26, 2025
Merged

Add link styles #2861

merged 9 commits into from
Feb 26, 2025

Conversation

zenoachtig
Copy link
Contributor

@zenoachtig zenoachtig commented Feb 20, 2025

Color (default):
Screenshot 2025-02-20 at 16 02 40

Underline:
Screenshot 2025-02-20 at 16 01 55

Copy link

changeset-bot bot commented Feb 20, 2025

🦋 Changeset detected

Latest commit: 0f77ce4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
gitbook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 20, 2025

Summary of the deployments:

Version 1 (production)

Version URL Status
Latest commit https://745e587f.gitbook-open.pages.dev
PR https://pr2861.gitbook-open.pages.dev

Version 2 (experimental)

Version URL Status
Vercel
Cloudflare

Test content

Site v1 v2
GitBook https://745e587f.gitbook-open.pages.dev/docs.gitbook.com /url/docs.gitbook.com
E2E https://745e587f.gitbook-open.pages.dev/gitbook.gitbook.io/test-gitbook-open /url/gitbook.gitbook.io/test-gitbook-open

@zenoachtig zenoachtig marked this pull request as ready for review February 24, 2025 12:43
Copy link

argos-ci bot commented Feb 26, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers (Inspect) 👍 Changes approved 94 changed Feb 26, 2025, 12:57 PM
default (Inspect) 👍 Changes approved 514 changed Feb 26, 2025, 1:01 PM

@zenoachtig zenoachtig enabled auto-merge (squash) February 26, 2025 11:17
@@ -23,9 +23,8 @@ export async function InlineLink(props: InlineProps<DocumentInlineLink>) {
}

return (
<Link
<StyledLink
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For better readability (and easier browsing in folders) we should place the modifier at the end in or names. Could we rename this LinkStyled? (can be done in a separate PR ofc)

@zenoachtig zenoachtig merged commit 027a859 into main Feb 26, 2025
13 of 15 checks passed
@zenoachtig zenoachtig deleted the link-styles branch February 26, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants