Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve detection of code path not supported in v2, add visual tests #2884

Merged
merged 6 commits into from
Feb 26, 2025

Conversation

SamyPesse
Copy link
Member

@SamyPesse SamyPesse commented Feb 26, 2025

It also fixes code highlighting regressing because of Biome.

Copy link

changeset-bot bot commented Feb 26, 2025

⚠️ No Changeset found

Latest commit: e5430ec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 26, 2025

@SamyPesse SamyPesse changed the title Improve detection of code path not supported in v2 Improve detection of code path not supported in v2, add visual tests Feb 26, 2025
Copy link

argos-ci bot commented Feb 26, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers (Inspect) 👍 Changes approved 4 changed Feb 26, 2025, 7:09 PM
customers-v2 (Inspect) 🔘 Orphan build (Review) 180 added, 2 failures Feb 26, 2025, 7:10 PM
default (Inspect) ⚠️ Changes detected (Review) 5 changed Feb 26, 2025, 7:11 PM
v2 (Inspect) 🔘 Orphan build (Review) 16 added, 159 failures Feb 26, 2025, 7:49 PM

@SamyPesse SamyPesse marked this pull request as ready for review February 26, 2025 19:03
@SamyPesse SamyPesse merged commit 31bcd1a into main Feb 26, 2025
12 of 17 checks passed
@SamyPesse SamyPesse deleted the v2-3 branch February 26, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant