Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change proxy mode site lookup url #2886

Merged
merged 2 commits into from
Feb 27, 2025
Merged

Conversation

taranvohra
Copy link
Member

No description provided.

Copy link

changeset-bot bot commented Feb 27, 2025

⚠️ No Changeset found

Latest commit: 3d579e3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 27, 2025

Copy link

argos-ci bot commented Feb 27, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers (Inspect) 👍 Changes approved 16 changed Feb 27, 2025, 6:54 AM
customers-v2 (Inspect) 👍 Changes approved 92 changed, 2 failures Feb 27, 2025, 6:56 AM
default (Inspect) ✅ No changes detected - Feb 27, 2025, 6:57 AM

@taranvohra taranvohra merged commit 4ed7957 into main Feb 27, 2025
14 of 17 checks passed
@taranvohra taranvohra deleted the taran/change-lookup-site-proxy branch February 27, 2025 07:08
@@ -433,7 +433,7 @@ async function lookupSiteInSingleMode(url: URL): Promise<LookupResult> {
* GITBOOK_MODE=proxy
* When proxying a site on a different base URL.
*/
async function lookupSiteInProxy(request: NextRequest, url: URL): Promise<LookupResult> {
async function lookupSiteInProxy(request: NextRequest, _url: URL): Promise<LookupResult> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This argument is now useless

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants