Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache OpenAPI using next "use cache" for v2 #2887

Conversation

SamyPesse
Copy link
Member

No description provided.

Copy link

linear bot commented Feb 27, 2025

Copy link

changeset-bot bot commented Feb 27, 2025

⚠️ No Changeset found

Latest commit: b3faa3f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 27, 2025

Copy link

argos-ci bot commented Feb 27, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers (Inspect) 👍 Changes approved 188 changed Feb 27, 2025, 8:35 AM
customers-v2 (Inspect) 👍 Changes approved 180 changed, 4 added Feb 27, 2025, 8:38 AM
default (Inspect) 👍 Changes approved 580 changed Feb 27, 2025, 8:37 AM

@SamyPesse SamyPesse marked this pull request as ready for review February 27, 2025 08:16
Copy link
Contributor

@gregberge gregberge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since use cache has no effect in v1, why not simplifying this code?

@SamyPesse SamyPesse merged commit ab132ea into main Feb 27, 2025
15 of 17 checks passed
@SamyPesse SamyPesse deleted the samy/rnd-6350-implement-openapi-caching-to-support-both-v1-and-v2 branch February 27, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants