Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how a site in proxy mode is resolved #2890

Merged
merged 2 commits into from
Feb 27, 2025
Merged

Conversation

taranvohra
Copy link
Member

@taranvohra taranvohra commented Feb 27, 2025

Some changes around proxy mode resolution to make it robust enough

Copy link

changeset-bot bot commented Feb 27, 2025

🦋 Changeset detected

Latest commit: 75ca2db

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
gitbook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

mode = 'proxy';
return {
mode: 'proxy',
url: new URL(xGitbookSite),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the proxy worker we send the entire URL that the user is trying to access, this is our inputURL

@taranvohra taranvohra marked this pull request as ready for review February 27, 2025 13:21
@taranvohra taranvohra requested a review from SamyPesse February 27, 2025 13:21
Copy link

argos-ci bot commented Feb 27, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers (Inspect) ⚠️ Changes detected (Review) 188 changed Feb 27, 2025, 1:22 PM
customers-v2 (Inspect) ⚠️ Changes detected (Review) 109 changed Feb 27, 2025, 1:24 PM
default (Inspect) 👍 Changes approved 576 changed, 4 added Feb 27, 2025, 1:26 PM

Copy link
Member

@SamyPesse SamyPesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but It looks a bit messy, should we lay down on paper the requests flow to make sure things are consistent?

@taranvohra taranvohra merged commit 2ae76f9 into main Feb 27, 2025
13 of 18 checks passed
@taranvohra taranvohra deleted the taran/proxy-mode-changes branch February 27, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants