Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove loading.tsx for static rendering in v2 #2894

Merged
merged 2 commits into from
Feb 27, 2025
Merged

Remove loading.tsx for static rendering in v2 #2894

merged 2 commits into from
Feb 27, 2025

Conversation

SamyPesse
Copy link
Member

This should fix the status code returned by Next.js for page not found.

Copy link

changeset-bot bot commented Feb 27, 2025

⚠️ No Changeset found

Latest commit: 8f834c8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 27, 2025

Copy link

argos-ci bot commented Feb 27, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers (Inspect) 👍 Changes approved 188 changed Feb 27, 2025, 4:34 PM
customers-v2 (Inspect) 👍 Changes approved 109 changed Feb 27, 2025, 4:37 PM
default (Inspect) 👍 Changes approved 576 changed, 4 added Feb 27, 2025, 4:39 PM

@SamyPesse SamyPesse marked this pull request as ready for review February 27, 2025 16:34
@SamyPesse SamyPesse merged commit 6e03638 into main Feb 27, 2025
16 of 18 checks passed
@SamyPesse SamyPesse deleted the fix-404 branch February 27, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant