Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenAPI spec recursion #2920

Merged
merged 3 commits into from
Mar 5, 2025
Merged

Fix OpenAPI spec recursion #2920

merged 3 commits into from
Mar 5, 2025

Conversation

gregberge
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Mar 4, 2025

⚠️ No Changeset found

Latest commit: 2f13d44

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

argos-ci bot commented Mar 4, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers (Inspect) 👍 Changes approved 10 changed Mar 5, 2025, 8:06 AM
customers-v2 (Inspect) 👍 Changes approved 12 changed Mar 5, 2025, 8:08 AM
default (Inspect) 👍 Changes approved 10 changed Mar 5, 2025, 8:09 AM

@gregberge gregberge marked this pull request as ready for review March 4, 2025 22:33
@gregberge gregberge changed the title Fix recursion Fix OpenAPI spec recursion Mar 4, 2025
@gregberge gregberge requested a review from nolannbiron March 4, 2025 22:34
return <OpenAPISchemaCircularRef id={parentCircularRef} schema={schema} />;
}

const circularRefs = parentCircularRefs.set(schema, id);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am mutating the parentCircularRefs which is bad but I don't understand why it does not work else...

I suspect streaming and Suspense to cut the rendering, start it again and never reach a point where it works.

@gregberge gregberge merged commit 259074b into main Mar 5, 2025
17 of 18 checks passed
@gregberge gregberge deleted the fix-recursion branch March 5, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants