Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enhance Cloud Run deploy command with advanced configuration options #40

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: Improve secret management and parsing in Cloud Run deployment
- Add robust secret reference parsing with support for multiple formats
- Enhance secret handling for environment variables and volume mounts
- Improve logging and error handling for secret configurations
- Update import paths to use personal GitHub repository
- Ensure consistent JSON serialization for secret-related fields
  • Loading branch information
dijarvrella committed Feb 27, 2025
commit 0c41a81e93d0c32f46ec54b7574c2b727e9cc649
6 changes: 3 additions & 3 deletions cmd/cloud-run/deploy.go
Original file line number Diff line number Diff line change
@@ -16,9 +16,9 @@ package main

import (
cloudbuild "cloud.google.com/go/cloudbuild/apiv1/v2"
"github.com/GoogleCloudBuild/cicd-images/cmd/cloud-run/pkg/build"
"github.com/GoogleCloudBuild/cicd-images/cmd/cloud-run/pkg/config"
"github.com/GoogleCloudBuild/cicd-images/cmd/cloud-run/pkg/deploy"
"github.com/dijarvrella/cicd-images/cmd/cloud-run/pkg/build"
"github.com/dijarvrella/cicd-images/cmd/cloud-run/pkg/config"
"github.com/dijarvrella/cicd-images/cmd/cloud-run/pkg/deploy"

"github.com/spf13/cobra"
"google.golang.org/api/option"
Loading
Oops, something went wrong.