Skip to content

Install size #19254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 79 commits into from
Mar 11, 2025
Merged

Install size #19254

merged 79 commits into from
Mar 11, 2025

Conversation

tyuwags
Copy link
Contributor

@tyuwags tyuwags commented Feb 6, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

resolve #18373

As discussed in the issue, these changes add the --ask option and the HOMEBREW_ASK environment variable to display the packages and dependencies that will be installed, along with their sizes, and prompt the user for input.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tyuwags, great work so far!

@tyuwags tyuwags marked this pull request as draft February 11, 2025 23:55
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work so far, I think we're almost there!

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work here @tyuwags! Thanks for your patience. Tried it out locally and worked as expected. You rock!

@MikeMcQuaid MikeMcQuaid enabled auto-merge March 11, 2025 09:52
@MikeMcQuaid MikeMcQuaid disabled auto-merge March 11, 2025 09:53
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Mar 11, 2025
Merged via the queue into Homebrew:master with commit ae7b0c1 Mar 11, 2025
31 checks passed
@tyuwags
Copy link
Contributor Author

tyuwags commented Mar 11, 2025

Thank you for your help too !
If you still see any incoherence, don't hesitate to tell me

@osalbahr
Copy link
Contributor

osalbahr commented Mar 11, 2025

Thank you for adding this feature!

nit: is there a reason there is a "yes" but not a "no"? (I tried it locally and typing "no" aborts, just checking before making a PR)

ohai "Do you want to proceed with the installation? [Y/y/yes/N/n]"


Edit: created the PR

osalbahr added a commit to osalbahr/brew that referenced this pull request Mar 11, 2025
@tyuwags
Copy link
Contributor Author

tyuwags commented Mar 12, 2025

No, it was mainly an oversight, thank you for adding it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

brew install should display download size
3 participants