-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install size #19254
base: master
Are you sure you want to change the base?
Install size #19254
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tyuwags, great work so far!
… and adding parameter
# Conflicts: # Library/Homebrew/vendor/bundle/bundler/setup.rb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work so far, I think we're almost there!
Library/Homebrew/install.rb
Outdated
puts "#{::Utils.pluralize("Formul", sized_formulae.count, plural: "ae", | ||
singular: "a")} \ | ||
(#{sized_formulae.count}): #{sized_formulae.join(", ")}\n\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
puts "#{::Utils.pluralize("Formul", sized_formulae.count, plural: "ae", | |
singular: "a")} \ | |
(#{sized_formulae.count}): #{sized_formulae.join(", ")}\n\n" | |
puts "#{::Utils.pluralize("Formula")} \ | |
(#{sized_formulae.count}): #{sized_formulae.join(", ")}\n\n" |
should work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not working, its adding a s to formula, should be ae
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, there's other usage of Utils.pluralize("Formula")
, can you see if they are working/broken?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cant see other usage of Utils.pluralize("Formula")
here the only method in Utils
def self.pluralize(stem, count, plural: "s", singular: "", include_count: false)
prefix = include_count ? "#{count} " : ""
suffix = (count == 1) ? singular : plural
"#{prefix}#{stem}#{suffix}"
end
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?resolve #18373
As discussed in the issue, these changes add the
--ask
option and theHOMEBREW_ASK
environment variable to display the packages and dependencies that will be installed, along with their sizes, and prompt the user for input.