-
-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Install size #19254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install size #19254
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tyuwags, great work so far!
… and adding parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work so far, I think we're almost there!
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work here @tyuwags! Thanks for your patience. Tried it out locally and worked as expected. You rock!
Thank you for your help too ! |
Thank you for adding this feature! nit: is there a reason there is a "yes" but not a "no"? (I tried it locally and typing "no" aborts, just checking before making a PR) brew/Library/Homebrew/install.rb Line 384 in 6278454
Edit: created the PR |
No, it was mainly an oversight, thank you for adding it |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?resolve #18373
As discussed in the issue, these changes add the
--ask
option and theHOMEBREW_ASK
environment variable to display the packages and dependencies that will be installed, along with their sizes, and prompt the user for input.