macOS pkg installer: fix existing installation not being upgraded #19406
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Currently when running the macOS installer atop an existing installation, at the point after the installation finishes but before
postinstall
is run, the master branch hasn't had its HEAD advanced to the latest tag yet so the working directory is in a "HEAD detached at {version number}" as though you had rungit checkout {version number}
. This is whygit reset --hard
resets it to the previous tagged version.This change has
git
find the latest tag (git tag --list --sort="-version:refname" | head -n1
) and then resets to that tag (git reset --hard <tag name>
). This also adds agit clean -f -d
to clear any stray untracked files from the working directory, and no longer purges all branches other thanmaster
.Fixes #19287, alternate to #19354. Tested on both macOS ARM and Intel.