Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cask shell completion #19410

Merged
merged 3 commits into from
Mar 5, 2025

Conversation

SMillerDev
Copy link
Member

@SMillerDev SMillerDev commented Mar 3, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Still need to check this on Linux, but this adds shell completion artifacts to casks and allows for a way to get the os_version without calling MacOS.full_version. That should make all casks readable on Linux and resolve the comments in https://github.com/orgs/goreleaser/discussions/5563

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable! Needs some more tests before merging.

@SMillerDev SMillerDev force-pushed the feat/cask/shell_completion branch from 2fecf7c to bff9d82 Compare March 4, 2025 09:03
@SMillerDev
Copy link
Member Author

Added tests for the shell completion stanzas, the os_version proved to be difficult to test and frankly not that essential either.

@SMillerDev SMillerDev force-pushed the feat/cask/shell_completion branch from 001c3cf to e80eb1b Compare March 4, 2025 19:25
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SMillerDev!

@SMillerDev SMillerDev force-pushed the feat/cask/shell_completion branch from e80eb1b to 327b12e Compare March 5, 2025 19:06
@SMillerDev SMillerDev enabled auto-merge March 5, 2025 19:12
@SMillerDev SMillerDev force-pushed the feat/cask/shell_completion branch from 327b12e to fc319f6 Compare March 5, 2025 19:12
@SMillerDev SMillerDev added this pull request to the merge queue Mar 5, 2025
Merged via the queue into Homebrew:master with commit 475ceb9 Mar 5, 2025
31 checks passed
@SMillerDev SMillerDev deleted the feat/cask/shell_completion branch March 5, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants