global: cleanup environment variables. #19421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
force-pushed
the
global_env_cleanup
branch
from
9d9cc33 to
19d2449
Compare
MikeMcQuaid
force-pushed
the
global_env_cleanup
branch
3 times, most recently
from
a241924 to
2a91c0f
Compare
carlocab
approved these changes
Mar 6, 2025
MikeMcQuaid
force-pushed
the
global_env_cleanup
branch
2 times, most recently
from
0bb4fbf to
c041dab
Compare
MikeMcQuaid
force-pushed
the
global_env_cleanup
branch
2 times, most recently
from
a486390 to
2a3e717
Compare
In the spirit of trying to cleanup e.g. `brew sh` or `brew bundle env` environment variables: let's delete them instead of fetching them. This avoids having `env` output all the environment variables that we're just using to pass state from Bash to Ruby.
MikeMcQuaid
force-pushed
the
global_env_cleanup
branch
from
2a3e717 to
d22184d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the spirit of trying to cleanup e.g.
brew shorbrew bundle envenvironment variables: let's delete them instead of fetching them.This avoids having
envoutput all the environment variables that we're just using to pass state from Bash to Ruby.