Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows/tests: use Docker image for Ubuntu 20.04 #19424

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Conversation

p-linnane
Copy link
Member

@p-linnane p-linnane commented Mar 4, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Brownouts have started for Ubuntu 20.04. Let's use our Docker image instead.

@p-linnane p-linnane force-pushed the ubuntu-20-to-22 branch 2 times, most recently from 34e2758 to 2b54889 Compare March 4, 2025 19:51
Signed-off-by: Patrick Linnane <patrick@linnane.io>
@p-linnane p-linnane changed the title workflows/tests: move from Ubuntu 20.04 to Ubuntu 22.04 workflows/tests: use Docker image for Ubuntu 20.04 Mar 4, 2025
@p-linnane
Copy link
Member Author

Alright with @Bo98's help we've got this working as expected. Updated the commit message to reflect the new approach.

@p-linnane p-linnane added this pull request to the merge queue Mar 4, 2025
Merged via the queue into master with commit 45f3e6c Mar 4, 2025
36 checks passed
@p-linnane p-linnane deleted the ubuntu-20-to-22 branch March 4, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants