Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: require strategic interface in each livecheck strategy #19425

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

dduugg
Copy link
Member

@dduugg dduugg commented Mar 4, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

…otherwise individual test runs will fail, e.g.

$ brew tests --only livecheck/strategy/gnome
Randomized with seed 14538
1 process for 1 spec, ~ 1 spec per process

An error occurred while loading ./test/livecheck/strategy/gnome_spec.rb.
Failure/Error: extend Strategic

NameError:
  uninitialized constant Homebrew::Livecheck::Strategy::Gnome::Strategic
# ./livecheck/strategy/gnome.rb:28:in `<class:Gnome>'
# ./livecheck/strategy/gnome.rb:27:in `<module:Strategy>'
# ./livecheck/strategy/gnome.rb:6:in `<module:Livecheck>'
# ./livecheck/strategy/gnome.rb:5:in `<module:Homebrew>'
# ./livecheck/strategy/gnome.rb:4:in `<top (required)>'
# ./test/livecheck/strategy/gnome_spec.rb:3:in `<top (required)>'

@p-linnane p-linnane added this pull request to the merge queue Mar 4, 2025
Merged via the queue into master with commit 79d750d Mar 4, 2025
29 of 30 checks passed
@p-linnane p-linnane deleted the fix-strategic-require branch March 4, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants