trae-cn 1.0.8055 (new cask)

[jinyu121]

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

• The submission is for a stable version or documented exception.
• brew audit --cask --online <cask> is error-free.
• brew style --fix <cask> reports no offenses.

Additionally, if adding a new cask:

• Named the cask according to the token reference.
• Checked the cask was not already refused (add your cask's name to the end of the search field).
• brew audit --cask --new <cask> worked successfully.
• HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
• brew uninstall --cask <cask> worked successfully.

---

Trae CN is a special edition of Trae:

1. It has a different homepage.
2. The model is different. Trae uses Claude, but Trae CN uses Doubao.
3. The account system may be different.
4. The package name, cache file name, config name, is "cn.something" rather than "com.something"

PS: It's Trae's official edition, not some wild custom edition.

[khipp]

Looks fine to me, but the token might be worth discussing. We have two existing casks with Chinese variants using different naming schemes: firefox and firefox@cn, as well as wpsoffice and wpsoffice-cn.

Since we usually use the @ symbol to denote specific versions or channels, I would suggest changing it to trae-cn.

[krehel]

Yeah I think I would agree here. We should be using @ for alpha, beta, etc. not different languages.

This is also probably worth a look through Casks and finding discrepancies and correcting.

[bevanjkay]

The token reference doesn't cleanly apply, because not every geographical variant will have a different app name.

In some cases it makes could make sense to use @ because the app path doesn't include cn - but when it does using a - does apply.

I lean towards using the @cn because it more clearly denotes that it's a variant of the main cask. If it's not an official distribution then this wouldn't apply.

[jinyu121]

I go through some of the casks

How @ is used:

• 1password-cli
• 1password-cli@1
• 1password-cli@beta
• ableton-live-suite@10
• ableton-live-suite@11
• affinity-designer
• affinity-designer@1
• android-studio
• android-studio-preview@beta
• android-studio-preview@canary

Seems @ is for specific version / release channel.

How - is used:

• amazon-workdocs
• amazon-workdocs-drive
• android-studio
• android-studio-preview@beta
• android-studio-preview@canary
  (In this case, - is for different variant, and @ is for specific channel / version)
• black-light
• black-light-pro
• blackhole-2ch
• blackhole-16ch
• blackhole-64ch
• blu-ray-player
• blu-ray-player-pro

Seems - is for different variant

---

So I will change @ to -. Thanks everyone.

[jinyu121]

Hi @khipp @krehel @bevanjkay , can you review it again? THX~

[bevanjkay]

Whichever direction we decide for the token, we should update the docs, and make sure the other casks are consistent here.

I still lean toward using the @ modifier in the case that it's a regional variant of an existing cask.
Where we can use a - if it is not a variant of an existing cask, or is fundamentally different.

[khipp]

I will let you make the call but would like to offer another perspective.

Using - would keep it more in line with the language stanza, which does not use the @ symbol. The language stanza still allows users to choose between different release channels (e.g., firefox --language=it and firefox@beta --language=it). However, this would no longer be possible in this instance:

• trae and trae@beta
• trae@cn and trae@cn-beta?

[bevanjkay]

Makes sense. I was thinking about this earlier.
Is there a way we can use the language stanza for trae-cn?

[khipp]

That should be possible, but it would be one of our more complex casks since we would also have to substitute parts of the artifact name and zap paths.
I could give it a try later so we can see how it looks.

[bevanjkay]

It's probably not worth the added complexity, we can leave it as is