Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new cask boringnotch #203798

Closed
wants to merge 2 commits into from
Closed

Conversation

singularitti
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@singularitti
Copy link
Contributor Author

This cask is a bit tricky: the version is not a series of numbers but a random name. I will ask the authors if they would like to change their version numbers to semantic versions.

@bevanjkay
Copy link
Member

bevanjkay commented Mar 4, 2025

The app isn't codesigned and notarized so we won't be able to include it in homebrew-cask at the moment anyway.

We should be able to handle having text as part of the version name.

@p-linnane
Copy link
Member

Closing per the above.

@p-linnane p-linnane closed this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants