Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial publish #11

Closed
nikitaeverywhere opened this issue Sep 6, 2020 · 7 comments · Fixed by #19
Closed

Initial publish #11

nikitaeverywhere opened this issue Sep 6, 2020 · 7 comments · Fixed by #19
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@nikitaeverywhere
Copy link
Contributor

nikitaeverywhere commented Sep 6, 2020 •
edited
Loading

Hello! Thanks for the great action.

I noticed it always fails saying

##[error]Error: Unable to determine the current version of @pkg/NAME on NPM.

...when you do a first publish of the package (when you're just starting a repository). You need to manually push the first version, and then it will work.

Is it intended or can be fixed? I guess we can add an error handler here.

Thank you.
@JamesMessinger
Copy link
Member

Good catch. I never thought about that because in my workflow the initial publish is usually done manually, not by CI/CD. But it makes total sense that this package should support that use case.

I'll leave this issue open and mark it as a bug to be fixed. I may not have the time to fix it for a while, but you're welcome to submit a PR if you have the time.

@JamesMessinger JamesMessinger added bug Something isn't working good first issue Good for newcomers labels Sep 7, 2020
nikitaeverywhere added a commit to nikitaeverywhere/npm-publish that referenced this issue Sep 7, 2020
@nikitaeverywhere
Fix first-time package publishing, fixes JS-DevTools#11
f46633e
nikitaeverywhere added a commit to nikitaeverywhere/npm-publish that referenced this issue Sep 7, 2020
@nikitaeverywhere
Fix first-time package publishing, fixes JS-DevTools#11
610099a
@nikitaeverywhere nikitaeverywhere mentioned this issue Sep 7, 2020
Merged
nikitaeverywhere added a commit to nikitaeverywhere/npm-publish that referenced this issue Sep 7, 2020
@nikitaeverywhere
Fix first-time package publishing, fixes JS-DevTools#11
02ef1cd
@nikitaeverywhere
Copy link
Contributor Author

Here we go!

@ShadyNagy ShadyNagy mentioned this issue Sep 7, 2020
Closed
@nikitaeverywhere
Copy link
Contributor Author

Ping @JamesMessinger there seems to be 2 PRs already to fix it, please review 😁

@varunsridharan
Copy link

@JamesMessinger great action. and i really need this feature. and waiting for your review on (#12 #13 ) pull request.

varunsridharan added a commit to g-actions/npm-publish that referenced this issue Sep 28, 2020
@varunsridharan
Merge pull request #1 from ZitRos/patch-2
71bb259 
Fix first-time package publishing, fixes JS-DevTools#11
JamesMessinger added a commit that referenced this issue Oct 1, 2020
@JamesMessinger
Merge pull request #12 from ZitRos/patch-2

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
e26eb1d 
Fix first-time package publishing, fixes #11
@JamesMessinger
Copy link
Member

Thank you @ZitRos and @ShadyNagy for submitting PRs for this issue! I merged @ZitRos's PR as it was more in-line with what I envisioned, but I appreciate both of you contributing!

@nikitaeverywhere
Copy link
Contributor Author

Thanks for a great action! We use it a lot 😌

@ShadyNagy
Copy link

Thank you so much 👍

@nikitaeverywhere nikitaeverywhere mentioned this issue Oct 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
5 participants
@varunsridharan @JamesMessinger @nikitaeverywhere @ShadyNagy and others