Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not working on Windows with latest version of Node.js #198

Closed
mcous opened this issue Jun 1, 2024 · 0 comments · Fixed by #199
Closed

Not working on Windows with latest version of Node.js #198

mcous opened this issue Jun 1, 2024 · 0 comments · Fixed by #199
Labels
bug Something isn't working

Comments

@mcous
Copy link
Member

mcous commented Jun 1, 2024 •
edited
Loading

Our method of shelling out to npm in Windows has been broken by a security fix in Node.js. Currently, all windows CI is failing due to this break.

See https://nodejs.org/en/blog/vulnerability/april-2024-security-releases-2 for details and resolution.
@mcous mcous added the bug Something isn't working label Jun 1, 2024
mcous added a commit that referenced this issue Jun 1, 2024
@mcous
fix(windows): allow spawning npm cli on windows
Loading
Loading status checks…
cdd51f2 
Fixes #198
@mcous mcous mentioned this issue Jun 1, 2024
Merged
@mcous mcous closed this as completed in #199 Jun 1, 2024
mcous added a commit that referenced this issue Jun 1, 2024
@mcous
fix(windows): allow spawning npm cli on windows (#199)
f45e793 
Fixes #198
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(windows): allow spawning npm cli on windows JS-DevTools/npm-publish
1 participant
@mcous