Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish function always reports publishing to NPM even when alternative registry is used #40

Closed
rorysedgwick opened this issue Aug 3, 2021 · 0 comments · Fixed by #45
Closed

Publish function always reports publishing to NPM even when alternative registry is used #40

rorysedgwick opened this issue Aug 3, 2021 · 0 comments · Fixed by #45

Comments

@rorysedgwick
Copy link

The package supports multiple registry URLs to publish to, however it always reports success/failure of publishing to NPM regardless of which registry was configured as the target.

Ideally it would parse the registry URL and determine which was being used, and report that.

For use cases where there may be multiple registries being published to, it becomes particularly useful to be able to avoid confusion about which was being use in a certain CI step, for example.

I imagine updating this string, and the equivalent in the CLI, to use an interpolation rather than the hardcoded NPM would do the trick.

Sample output from a Github Workflow running this action and publishing to the Github Package Registry:

Run JS-DevTools/npm-publish@v1
  with:
    token: ***
    registry: https://npm.pkg.github.com/
    package: package.json
    tag: latest
    dry-run: false
    check-version: true

> @<scope>/github-package-publish-test@0.0.3 prepublishOnly .
> npm test && npm run lint


> @<scope>/github-package-publish-test@0.0.3 test /home/runner/work/github-package-publish-test/github-package-publish-test
> jest --config jestconfig.json

PASS src/__tests__/index.test.ts
  ✓ init (2 ms)

Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   0 total
Time:        1.133 s, estimated 3 s
Ran all test suites.

> @<scope>/github-package-publish-test@0.0.3 lint /home/runner/work/github-package-publish-test/github-package-publish-test
> tslint -p tsconfig.json

npm notice 
npm notice 📦  @<scope>/github-package-publish-test@0.0.3
npm notice === Tarball Contents === 
npm notice 189B  dist/index.js  
npm notice 1.5kB package.json   
npm notice 1.1kB README.md      
npm notice 42B   dist/index.d.ts
npm notice === Tarball Details === 
npm notice name:          @<scope>/github-package-publish-test 
npm notice version:       0.0.3                                   
npm notice package size:  1.3 kB                                  
npm notice unpacked size: 2.9 kB                                  
npm notice shasum:        d509a842e5f47f0ba3b154328a286e402ba983b3
npm notice integrity:     sha512-wrpD7XDhT+nKT[...]Vn5MxPGw8DxQA==
npm notice total files:   4                                       
npm notice 
+ @<scope>/github-package-publish-test@0.0.3

📦 Successfully published @<scope>/github-package-publish-test v0.0.3 to NPM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change log message when publishing package to other specified registry 6thpath/npm-publish
1 participant
@rorysedgwick