Add support for npm publish --dry-run #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an extra Option/command line argument to optionally run npm publish with the --dry-run flag enabled to prevent actual publishing. Intended for use in testing workflows. This option/argument defaults to false.
JamesMessinger
requested changes
Jul 22, 2020
src/npm-publish.ts
Outdated
| @@ -25,7 +25,7 @@ export async function npmPublish(opts: Options = {}): Promise<Results> { | |||
|
|
|||
| let results: Results = { | |||
| package: manifest.name, | |||
| type: diff || "none", | |||
| type: options.dryRun ? "dry-run" : (diff || "none"), | |||
There was a problem hiding this comment.
Instead of overloading the type property, let's add a new property to the Results object (i.e. dryRun: boolean). That way, scripts can still check the type property like normal, regardless of whether it was a dry run or not.
| debug: debugHandler, | ||
| }; | ||
|
|
||
| // Puglish to NPM | ||
| // Publish to NPM |
There was a problem hiding this comment.
Thank you for fixing my typos. 🤦♂️
| @@ -25,7 +25,7 @@ export const npm = { | |||
|
|
|||
| options.debug(`Running command: npm view ${name} version`); | |||
|
|
|||
| // Run NPM to get the latest published versiono of the package | |||
| // Run NPM to get the latest published version of the package | |||
There was a problem hiding this comment.
Thank you for fixing my typos. 🤦♂️
|
@JamesMessinger thanks for the feedback. |
JamesMessinger
approved these changes
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #6: Add an extra Option/command line argument to optionally run npm publish with the --dry-run flag enabled to prevent
actual publishing. Intended for use in testing workflows. This option/argument defaults to false.
Wasn't sure if build files should be committed, so I left them out for now.