Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors swallowed in watch mode #1

Closed
paulcpederson opened this issue Aug 5, 2015 · 0 comments · Fixed by #2
Closed

Errors swallowed in watch mode #1

paulcpederson opened this issue Aug 5, 2015 · 0 comments · Fixed by #2

Comments

@paulcpederson
Copy link
Contributor

Say you have a JavaScript file named gloob.js with an invalid syntax like:

var gloob = hello())

If you run simplifyify gloob.js it correctly reports the error and exits.

If, however, you run simplifyify gloob.js -w. When you save the file and introduce this error, it simply reports that the file is changed. The error is not reported. The output bundle file will be blank, but nothing indicates that there was an error.

I did a bit of poking around and it seems that the error event is not firing in bin/simplifyify.js or in lib/index.js. Perhaps it is being swallowed in write-bundles.js?

I could try writing a failing test for this and submitting a pr if that would help. I'm not super experienced with chai, but I could probably figure it out.

Oh, and also simplifyify is pretty awesome. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant