Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch errors #2

Merged
merged 2 commits into from
Aug 10, 2015
Merged

Watch errors #2

merged 2 commits into from
Aug 10, 2015

Conversation

paulcpederson
Copy link
Contributor

This tests and fixes #1

A couple things:

  1. If in watch mode, doesn't exit the process. In this way, if you have an error you can see it, then fix it and simplifyify will rebundle, no need to restart the process.
  2. I'm logging the full error if the error is created during the bundling process. I don't think hiding that behind a process.env flag makes sense. Most developers will need that information to fix the error.
  3. I added the test fixture for this to the ignore for linting as it intentionally includes a syntax error.

@paulcpederson
Copy link
Contributor Author

@BigstickCarpet let me know if this makes sense, happy to rework or update anything if need be.

@JamesMessinger
Copy link
Member

Hi. Sorry for the delayed response. I've been away on vacation, and I'm just now getting through my backlog of emails.

Thanks for submitting this. I'll take a look at it right now.

JamesMessinger added a commit that referenced this pull request Aug 10, 2015
@JamesMessinger JamesMessinger merged commit 46b98bf into JS-DevTools:master Aug 10, 2015
JamesMessinger added a commit that referenced this pull request Aug 10, 2015
@JamesMessinger
Copy link
Member

Alright. This has been released as v1.4.0. Thank you so much for the contribution!

@paulcpederson
Copy link
Contributor Author

@BigstickCarpet 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors swallowed in watch mode
2 participants